AccessKit Disable GIFs: Parse; disable animated WebP images #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcustyphoon
force-pushed
the
webp-riffchunks
branch
from
c4282e8 to
b5cb833
Compare
marcustyphoon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This applies Disable GIFs to animated WebP images by fetching their binary data and finding the
ANIMchunk.Honestly, this was just the offshoot of a failed attempt to parse the WebP binary myself (https://developers.google.com/speed/webp/docs/riff_container). I totally can do it, and if the necessary information was in the bit flags in the VP8X header I would, but that bit seems to be set to 1 even on non-animated images and the
ANIMheader's position has to be searched for, and it just winds up as way too much handwritten code to document succinctly as a one-off. So this just vendors a library. Booooorring.Resolves #1401.
Testing steps