Show Originals: Function on blogs on Tumblr Patio UI #1377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This improves and cleans up the code that Show Originals uses to determine what mode to apply to a timeline, making it treat user blogs viewed in the in the "Tumblr Patio" feature preview the same way it treats the blog view modal.
Specifically:
timeline
property instead of assuming anything in a blog view container is a blog. The regex is specific enough to exclude single post views, so extra code is not needed to exclude them.Testing steps
Confirm that Show Originals inserts its control element and functions on:
Confirm that Show Originals does not insert its control element on: