Show Originals: Allow filtering whitelisted/own blogs #1367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of those things that feels like an easy functionality win but is immediately hard to explain and reason about every consequence of once you think about it at all. Don't worry about merging this too much; I'm probably one of a fairly small number of people who want it.
Description
This quality of life tweak slightly adjusts the behavior of Show Originals' whitelist and "always show my own reblogs" settings. Previously, they would cause viewing a blog that you have whitelisted or own in the blog view to unconditionally show every post, so the Show Originals controls were locked to
All Posts
on those blogs. Sometimes one wants to filter original posts from a specific blog to find something, and having to temporarily un-whitelist it or turn off the own reblogs checkbox to do so feels a bit silly.This replaces the lock with a "default to
All Posts
but enable both buttons" behavior on those blogs, and ignores the own-reblogs and whitelist rules when processing posts in the blog view so that the originals-only modes work when clicked.Caveat: With the current simple-ish PR code, this means there's no longer a way to filter a group blog you're part of by "original posts and my reblogs." For correctness, this tweak to the post processing (ignoring the own-reblogs and whitelist rules) should apply only to blog view blogs whose posts would unconditionally otherwise be shown, i.e. whitelisted blogs and own non-group blogs, but that's a bit hard to represent in code succinctly; still poking at it.
Testing steps