Code correctness fixes from typing experiment #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AprilSylph
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per our discussion (#1234 (comment)) in #1234, this fixes a few places where we accidentally passed non-array values to
showModal, something which would have been caught by a type checker, and adjusts a few JSDoc entries that said type checker would have complained about.To do this, I—naturally—tried setting up
tscon the repository, because come on. Who do you think I am?Testing steps
The only functional change expected here, because of the fact that one can use a spread operator on a string, is that Limit Checker's error handler no longer crashes. Thus:
With this PR there should be an error message; without it the progress screen should stall forever.