-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing .preprocessed.yml #83 #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, but couple of requests:
- We need to update
.gitignore
files too. - Remove any notion of that feature from the documentation.
- This feature should land in
2.0
so destination branch should berelease_2_0
, notmaster
.
I see that @SylwiaGargula commits are re-created in this PR. Shouldn't you:
Is it correct? |
Yup, @jlampar is correct. Please rebase your branch on top of release_2_0 first. |
The last line should be:
|
Now it looks much better @piwowarc - I've one more request - can we squash and rewrite history for that branch (or just clean it, in another way). |
I removed code which allowed to generate .preprocessed.yml file.