-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change marquee to singlescrollview #998
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierPaquet-Rapold
force-pushed
the
hotfix/grade-details-view-bug
branch
from
June 24, 2024 02:22
f64552d
to
1fc8d23
Compare
Quality Gate passedIssues Measures |
LouisPhilippeHeon
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When expanding a grade evaluation tile, the text disappears and an
RenderBox was not laid out
exception.📖 Description
The solution is to use
SingleChildScrollView
instead ofMarquee
.The current behaviour is that if an evaluation title is too long, it automatically flows on the screen horizontally.
Advantages:
Disadvantages:
🧪 How Has This Been Tested?
☑️ Checklist before requesting a review
version: Major
,version: Minor
orversion: Patch
.