Add android themed icons support #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing for the CI to build correctly |
|
@edgarogh Can you increment the patch version in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #916
📖 Description
I really just added a single line of XML code, reusing the existing adaptive icon drawable
🧪 How Has This Been Tested?
Tested both in the emulator and on my own phone. Due to not having access to some required keys, and being unable to downgrade dart to the old version that you're using, I had to strip out all flutter code and build it as a normal android app, just for testing. The nature of the change probably doesn't warrant any additional testing.
🖼️ Screenshots
First screenshot shows the app launcher without Themed Icons enabled, and the second shows how it now looks with Themed Icons enabled.
The ÉTS icon's outline looks less sharp than other icons, I'm not sure what causes that. Since the source file is a PNG, I can't really edit it as I would've done with an SVG. That'll be ok I guess anyway, but if somebody has an SVG version of the icon with a sharper outline, it might look ever-so-slightly better.