Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/fix ios build #878

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Hotfix/fix ios build #878

merged 4 commits into from
Oct 27, 2023

Conversation

XavierPaquet-Rapold
Copy link
Contributor

@XavierPaquet-Rapold XavierPaquet-Rapold commented Oct 27, 2023

⁉️ Related Issue

Fix certificate and pods ios deployment target
📖 Description
🧪 How Has This Been Tested?

Build succeeded
☑️ Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • If needed, I added analytics.
  • Make sure to add either one of the following labels: version: Major,version: Minor or version: Patch.
  • Make sure golden files changes were reviewed and approved.

🖼️ Screenshots (if useful):

@github-actions github-actions bot added size: M and removed size: S labels Oct 27, 2023
@clubapplets-server
Copy link
Member

LGTM! 💯 -Sam

@github-actions
Copy link

Coverage after merging hotfix/fix-ios-build into master will be

79.43%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib
   locator.dart4.35%100%100%4.35%28, 30–42, 45–49, 52–54
lib/core/constants
   preferences_flags.dart0%100%100%0%63, 68, 70, 72–74, 77, 79–82, 84, 86
   widget_helper.dart100%100%100%100%
   quick_links.dart100%100%100%100%
   emergency_procedures.dart100%100%100%100%
   markers.dart100%100%100%100%
lib/core/managers
   cache_manager.dart0%100%100%0%30–31, 34–37, 40, 44, 46–49, 51, 59, 61–63, 65, 72, 74–77
   course_repository.dart96.74%100%100%96.74%242, 250, 252–253, 428–429, 500
   quick_link_repository.dart85.71%100%100%85.71%39–40
   settings_manager.dart88.98%100%100%88.98%217, 223, 226, 230, 232, 252, 254–255, 268, 270–272, 39, 88
   user_repository.dart94.96%100%100%94.96%310–312, 96–98
lib/core/models
   feedback_issue.dart100%100%100%100%
   quick_link.dart100%100%100%100%
   quick_link_data.dart100%100%100%100%
   widget_models.dart100%100%100%100%
   discovery.dart100%100%100%100%
   group_discovery.dart100%100%100%100%
   emergency_procedure.dart100%100%100%100%
   faq_actions.dart100%100%100%100%
   faq_questions.dart100%100%100%100%
lib/core/services
   preferences_service.dart68.52%100%100%68.52%120–121, 123, 37, 39, 41, 44–46, 70–71, 81–83, 86, 88–89
   analytics_service.dart0%100%100%0%16–17, 20, 23–25, 28, 33, 35–37, 41–43, 45
   app_widget_service.dart80%100%100%80%71, 73–78
   github_api.dart0%100%100%0%100, 103, 108, 110–114, 116–117, 120, 128–131, 135–136, 138, 39, 42–43, 47, 51–55, 57–58, 60, 62, 64–65, 68, 76, 81–87, 91, 93, 95–97, 99
   in_app_review_service.dart0%100%100%0%16, 20, 23, 27
   internal_info_service.dart0%100%100%0%18–21, 24–29, 32, 34–38, 42–43
   launch_url_service.dart0%100%100%0%22–24, 27–29, 32–33, 35–36, 42, 60–61, 64
   navigation_service.dart0%100%100%0%21, 24–26, 33–36, 38–39, 44, 47–49, 51–52
   networking_service.dart0%100%100%0%10–11, 13–15, 18–20
   remote_config_service.dart0%100%100%0%100–102, 104, 109–111, 41–43, 46–48, 51–53, 56–58, 61–63, 66–68, 71–73, 76–78, 81–83, 86–88, 91–93, 96–97, 99
   rive_animation_service.dart0%100%100%0%13–14, 17, 20–21, 29, 33–34, 36
   siren_flutter_service.dart0%100%100%0%13–14, 18–19, 23–25, 29–31, 35, 41
lib/core/utils
   cache_exception.dart33.33%100%100%33.33%13, 15
   animation_exception.dart20%100%100%20%18, 20–22
   utils.dart70.83%100%100%70.83%12–15, 17–18, 50
   login_mask.dart5%100%100%5%12, 15–16, 18–20, 23–30, 33–34, 37–39
lib/core/viewmodels
   quick_links_viewmodel.dart100%100%100%100%
   startup_viewmodel.dart92.50%100%100%92.50%103, 138–139
   grades_viewmodel.dart100%100%100%100%
   more_viewmodel.dart80.49%100%100%80.49%103–105, 107–108, 110, 115–116
   profile_viewmodel.dart92.45%100%100%92.45%129–130, 78, 81
   faq_viewmodel.dart41.67%100%100%41.67%30, 32–33, 35, 38, 41, 43
   settings_viewmodel.dart100%100%100%100%
   choose_language_viewmodel.dart100%100%100%100%
   schedule_viewmodel.dart88.95%100%100%88.95%100–102, 117, 243, 248–249, 284, 327–331, 340–341, 389–390, 98–99
   schedule_settings_viewmodel.dart69.23%100%100%69.23%106–110, 126, 128, 130, 133, 136, 138–139, 64, 66–71, 95–99
   grades_details_viewmodel.dart100%100%100%100%
   dashboard_viewmodel.dart84.39%100%100%84.39%226–227, 241–245, 247, 256–257, 299, 339–341, 346, 449, 465–467, 469, 474–475, 532–533, 538, 540, 542, 544, 546, 549–550, 552, 555, 557, 559–560, 562–563, 566–567, 579–580
   web_link_card_viewmodel.dart62.50%100%100%62.50%35, 40–41
   login_viewmodel.dart100%100%100%100%
   feedback_viewmodel.dart79.41%100%100%79.41%63–64, 66–68, 70–71
   not_found_viewmodel.dart100%100%100%100%
   emergency_viewmodel.dart7.69%100%100%7.69%21–22, 24–25, 27–29, 33, 35–36, 43–44
   security_viewmodel.dart50%100%100%50%37–38, 42–44, 46, 51–52
lib/ui/utils
   app_theme.dart0%100%100%0%6, 72–74, 77–82, 86–88, 94–99
   discovery_components.dart93.23%100%100%93.23%102, 133, 164, 194, 224, 40, 458, 465–466, 468, 470–475, 71
   loading.dart100%100%100%100%
lib/ui/views
   profile_view.dart97.89%100%100%97.89%126, 347, 39
   emergency_view.dart52.17%100%100%52.17%34–40, 51–54
   choose_language_view.dart94.59%100%100%94.59%34–35
   security_view.dart75.41%100%100%75.41%108, 110–114, 45–47, 66–71
   grade_details_view.dart95.68%100%100%95.68%141, 306, 66, 68–69, 74, 99
   feedback_view.dart70.51%100%100%70.51%105, 108–109, 111–115, 117, 122, 126, 128–130, 133–136, 138, 147–149, 156–162, 275–276, 325–327, 329, 331, 333, 335, 39–40, 42–43, 67–68, 70–71
   about_view.dart71.64%100%100%71.64%129–130, 136–137, 143–144, 150–151, 157–158, 164–165, 170, 173, 175, 23–25, 92
   quick_links_view.dart61.25%100%100%61.25%121–123, 137–140, 155, 157, 160, 168–169, 176, 179–181, 188–189, 196, 199–201, 63–67, 88–89, 92–93
   more_view.dart85.37%100%100%85.37%110–112, 195–196, 198, 202, 234–236, 238,

@XavierPaquet-Rapold XavierPaquet-Rapold merged commit 56726ac into master Oct 27, 2023
14 checks passed
@XavierPaquet-Rapold XavierPaquet-Rapold deleted the hotfix/fix-ios-build branch October 27, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants