Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/reordable links #849

Merged
merged 24 commits into from
Sep 22, 2023
Merged

Feature/reordable links #849

merged 24 commits into from
Sep 22, 2023

Conversation

JonathanDuvalV
Copy link
Contributor

@JonathanDuvalV JonathanDuvalV commented Sep 19, 2023 •
edited
Loading

⁉️ Related Issue

Closes #820

📖 Description

This PR makes the quicklinks in the "ETS" tab reordable by holding for 1 second on any of the WebLinkCard. The QuickLinks can also be deleted or added back

Here is a short demo:

Demo.mp4

🧪 How Has This Been Tested?

Tests were added for the new viewmodel and repository for QuickLinks. Other quicklink related tests were modified to fit the new structure.

☑️ Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • If needed, I added analytics.
  • Make sure to add either one of the following labels: version: Major,version: Minor or version: Patch.
  • Make sure golden files changes were reviewed and approved.

@JonathanDuvalV JonathanDuvalV requested a review from a team as a code owner September 19, 2023 21:41
@JonathanDuvalV JonathanDuvalV self-assigned this Sep 19, 2023
@JonathanDuvalV
Copy link
Contributor Author

J'ai pas pensé en faisant la tâche 😅, mais on voudrait quoi comme couleur pour la bulle du "x" en light theme?

image

camillebrulotte
camillebrulotte reviewed Sep 20, 2023
View reviewed changes
lib/locator.dart Outdated Show resolved Hide resolved
camillebrulotte
camillebrulotte reviewed Sep 20, 2023
View reviewed changes
test/helpers.dart Outdated Show resolved Hide resolved
@camillebrulotte
Copy link
Contributor

La couleur c'est fine ! C'est comme les icones dans la bar de nav ! Good job à part pour les imports !! 🚨 Je rigole

@JonathanDuvalV
Copy link
Contributor Author

La couleur c'est fine ! C'est comme les icones dans la bar de nav ! Good job à part pour les imports !! 🚨 Je rigole

C'est corrigé! En tout cas je crois que les imports sont au bon endroit maintenant 😆 Je promets que je recommencerai pu, désolé police des imports 😭

XavierPaquet-Rapold
XavierPaquet-Rapold previously approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@XavierPaquet-Rapold XavierPaquet-Rapold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@github-actions
Copy link

Coverage after merging feature/reordable_links into master will be

79.79%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib
   locator.dart4.35%100%100%4.35%32, 34–46, 49–53, 56–58
lib/core/constants
   preferences_flags.dart0%100%100%0%58, 63, 65, 67–69, 72, 74–77, 79, 81
   quick_links.dart100%100%100%100%
   widget_helper.dart100%100%100%100%
   emergency_procedures.dart100%100%100%100%
   markers.dart100%100%100%100%
lib/core/managers
   user_repository.dart94.96%100%100%94.96%100–101, 313–315, 99
   cache_manager.dart0%100%100%0%31–32, 35–38, 41, 45, 47–50, 52, 60, 62–64, 66, 73, 75–78
   course_repository.dart96.74%100%100%96.74%244, 252, 254–255, 430–431, 502
   settings_manager.dart88.62%100%100%88.62%212, 218, 221, 225, 227, 247, 249–250, 263, 265–267, 41, 90
   quick_link_repository.dart85.71%100%100%85.71%43–44
lib/core/models
   quick_link.dart100%100%100%100%
   quick_link_data.dart100%100%100%100%
   feedback_issue.dart100%100%100%100%
   discovery.dart100%100%100%100%
   group_discovery.dart100%100%100%100%
   widget_models.dart100%100%100%100%
   emergency_procedure.dart100%100%100%100%
lib/core/services
   navigation_service.dart0%100%100%0%19, 22–24, 31–34, 36–37, 42, 45–47, 49–50
   analytics_service.dart0%100%100%0%14–15, 18, 21–23, 26, 31, 33–35, 39–41, 43
   rive_animation_service.dart0%100%100%0%11–12, 15, 18–19, 27, 31–32, 34
   preferences_service.dart68.52%100%100%68.52%116–117, 119, 33, 35, 37, 40–42, 66–67, 77–79, 82, 84–85
   github_api.dart0%100%100%0%100, 103, 108, 110–114, 116–117, 120, 128–131, 135–136, 138, 39, 42–43, 47, 51–55, 57–58, 60, 62, 64–65, 68, 76, 81–87, 91, 93, 95–97, 99
   networking_service.dart0%100%100%0%11–13, 16–18, 8–9
   internal_info_service.dart0%100%100%0%14–17, 20–25, 28, 30–34, 38–39
   siren_flutter_service.dart0%100%100%0%11–12, 16–17, 21–23, 27–29, 33, 39
   app_widget_service.dart80%100%100%80%67, 69–74
   in_app_review_service.dart0%100%100%0%14, 18, 21, 25
   launch_url_service.dart0%100%100%0%18–20, 23–25, 28–29, 31–32, 38, 56–57, 60
   remote_config_service.dart0%100%100%0%20–22, 25–27, 30–32, 35–36, 38–41, 43, 48–50
lib/core/utils
   cache_exception.dart33.33%100%100%33.33%13, 15
   animation_exception.dart20%100%100%20%18, 20–22
   utils.dart70.83%100%100%70.83%10–13, 15–16, 48
   login_mask.dart5%100%100%5%11, 14–15, 17–19, 22–29, 32–33, 36–38
lib/core/viewmodels
   grades_viewmodel.dart100%100%100%100%
   dashboard_viewmodel.dart84.87%100%100%84.87%215–216, 230–234, 236, 245–246, 288, 417, 433–435, 437, 442–443, 500–501, 506, 508, 510, 512, 514, 517–518, 520, 523, 525, 527–528, 530–531, 534–535
   grades_details_viewmodel.dart100%100%100%100%
   more_viewmodel.dart80.49%100%100%80.49%109–111, 113–114, 116, 121–122
   schedule_viewmodel.dart88.95%100%100%88.95%104–108, 123, 249, 254–255, 290, 333–337, 346–347, 395–396
   schedule_settings_viewmodel.dart69.23%100%100%69.23%101–105, 112–116, 132, 134, 136, 139, 142, 144–145, 70, 72–77
   login_viewmodel.dart100%100%100%100%
   quick_links_viewmodel.dart100%100%100%100%
   startup_viewmodel.dart92.50%100%100%92.50%107, 142–143
   profile_viewmodel.dart96.23%100%100%96.23%135–136
   choose_language_viewmodel.dart100%100%100%100%
   settings_viewmodel.dart100%100%100%100%
   feedback_viewmodel.dart79.41%100%100%79.41%65–66, 68–70, 72–73
   not_found_viewmodel.dart100%100%100%100%
   web_link_card_viewmodel.dart62.50%100%100%62.50%37, 42–43
   emergency_viewmodel.dart7.69%100%100%7.69%17–18, 20–21, 23–25, 29, 31–32, 39–40
   security_viewmodel.dart50%100%100%50%37–38, 42–44, 46, 51–52
lib/ui/utils
   app_theme.dart0%100%100%0%5, 71–73, 76–81, 85–87, 93–98
   discovery_components.dart92.89%100%100%92.89%108, 139, 170, 200, 230, 441, 448–449, 451, 453–458, 46, 77
   loading.dart100%100%100%100%
lib/ui/views
   more_view.dart84.35%100%100%84.35%116–118, 188–189, 191, 195, 227–229, 231, 233–235, 50–51, 70–71
   choose_language_view.dart94.59%100%100%94.59%36–37
   login_view.dart80.73%100%100%80.73%126–128, 158–159, 161, 174, 176, 178–180, 183, 189, 199, 258–259, 261–262, 64–66
   about_view.dart71.64%100%100%71.64%129–130, 136–137, 143–144, 150–151, 157–158, 164–165, 170, 173, 175, 23–25, 92
   grades_view.dart96.36%100%100%96.36%135, 52
   dashboard_view.dart82.76%100%100%82.76%156–158, 166–168, 176–178, 186–188, 226–229, 243–245, 261, 263–264, 282–285, 289–291, 317–318, 368–369, 426, 95
   grade_details_view.dart95.68%100%100%95.68%103, 145, 310, 70, 72–73, 78
   settings_view.dart100%100%100%100%
   feedback_view.dart70.51%100%100%70.51%107, 110–111, 113–117, 119, 124, 128, 130–132, 135–138, 140, 149–151, 158–164, 277–278, 327–329, 331, 333, 335, 337, 41–42, 44–45, 69–70, 72–73
   security_view.dart75.41%100%100%75.41%110, 112–116, 47–49, 68–73
   emergency_view.dart52.17%100%100%52.17%34–40, 51–54
   schedule_view.dart53.52%100%100%53.52%103, 105, 112–117, 119–120, 122–123, 125–129, 131–132,

camillebrulotte
camillebrulotte approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@camillebrulotte camillebrulotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@JonathanDuvalV JonathanDuvalV merged commit 3ec46ac into master Sep 22, 2023
7 checks passed
@JonathanDuvalV JonathanDuvalV deleted the feature/reordable_links branch September 22, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierPaquet-Rapold XavierPaquet-Rapold XavierPaquet-Rapold approved these changes

@camillebrulotte camillebrulotte camillebrulotte approved these changes

Assignees

@JonathanDuvalV JonathanDuvalV

Labels
size: L version: Minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reorderable links in Quicklinks
3 participants
@JonathanDuvalV @camillebrulotte @XavierPaquet-Rapold