Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/News Card Component #827

Merged
merged 22 commits into from
Sep 17, 2023
Merged

Feature/News Card Component #827

merged 22 commits into from
Sep 17, 2023

Conversation

Udito3
Copy link
Contributor

@Udito3 Udito3 commented Jul 17, 2023

⁉️ Related Issue

Closes #765

📖 Description

Added a news card component to be used in the news page.
Added a start of a repository, viewmodel and models.
The code for the news card is commented in the dashboard ui to be moved in the future.

🧪 How Has This Been Tested?

Unit tests for the repository, viewmodel and models.
To see the news cards you can uncomment the lines in the dashboard ui.

☑️ Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • If needed, I added analytics.
  • Make sure to add either one of the following labels: version: Major,version: Minor or version: Patch.
  • Make sure golden files changes were reviewed and approved.

🖼️ Screenshots (if useful):

image image

Sorry, something went wrong.

@Udito3 Udito3 added enhancement New feature or request hello labels Jul 17, 2023
@Udito3 Udito3 requested a review from a team as a code owner July 17, 2023 00:51
@Udito3 Udito3 self-assigned this Jul 17, 2023
@ApplETS ApplETS deleted a comment from github-actions bot Jul 17, 2023
Copy link
Contributor

@HugoMigner HugoMigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥 🚒 🧯 🧑‍🚒 💧 🏠

Copy link
Contributor

@camillebrulotte camillebrulotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@github-actions
Copy link

Coverage after merging feature/news_card into hello/master will be

79.49%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib
   locator.dart4.35%100%100%4.35%32, 34–46, 49–53, 56–58
lib/core/constants
   preferences_flags.dart0%100%100%0%58, 63, 65, 67–69, 72, 74–77, 79, 81
   widget_helper.dart100%100%100%100%
   emergency_procedures.dart100%100%100%100%
   markers.dart100%100%100%100%
   quick_links.dart100%100%100%100%
lib/core/managers
   user_repository.dart94.96%100%100%94.96%100–101, 313–315, 99
   cache_manager.dart0%100%100%0%31–32, 35–38, 41, 45, 47–50, 52, 60, 62–64, 66, 73, 75–78
   course_repository.dart96.74%100%100%96.74%245, 253, 255–256, 431–432, 503
   settings_manager.dart88.43%100%100%88.43%209, 215, 218, 222, 224, 244, 246–247, 260, 262–264, 41, 87
   news_repository.dart61.54%100%100%61.54%109, 111–112, 118–119, 122, 125–127, 129–133, 90
lib/core/models
   feedback_issue.dart100%100%100%100%
   news.dart100%100%100%100%
   tags.dart90.91%100%100%90.91%19
   discovery.dart100%100%100%100%
   group_discovery.dart100%100%100%100%
   widget_models.dart100%100%100%100%
   quick_link.dart100%100%100%100%
   emergency_procedure.dart100%100%100%100%
lib/core/services
   navigation_service.dart0%100%100%0%19, 22–24, 31–34, 36–37, 42, 45–47, 49–50
   analytics_service.dart0%100%100%0%14–15, 18, 21–23, 26, 31, 33–35, 39–41, 43
   rive_animation_service.dart0%100%100%0%11–12, 15, 18–19, 27, 31–32, 34
   preferences_service.dart68.52%100%100%68.52%116–117, 119, 33, 35, 37, 40–42, 66–67, 77–79, 82, 84–85
   github_api.dart0%100%100%0%100, 103, 108, 110–114, 116–117, 120, 128–131, 135–136, 138, 39, 42–43, 47, 51–55, 57–58, 60, 62, 64–65, 68, 76, 81–87, 91, 93, 95–97, 99
   networking_service.dart0%100%100%0%11–13, 16–18, 8–9
   internal_info_service.dart0%100%100%0%14–17, 20–25, 28, 30–34, 38–39
   siren_flutter_service.dart0%100%100%0%11–12, 16–17, 21–23, 27–29, 33, 39
   app_widget_service.dart80%100%100%80%67, 69–74
   in_app_review_service.dart0%100%100%0%14, 18, 21, 25
   launch_url_service.dart0%100%100%0%10–12, 5–7
   remote_config_service.dart0%100%100%0%20–22, 25–27, 30–32, 35–36, 38–41, 43, 48–50
lib/core/utils
   cache_exception.dart33.33%100%100%33.33%13, 15
   animation_exception.dart20%100%100%20%18, 20–22
   utils.dart65.38%100%100%65.38%10–13, 15–16, 35–36, 52
   login_mask.dart5%100%100%5%11, 14–15, 17–19, 22–29, 32–33, 36–38
lib/core/viewmodels
   grades_viewmodel.dart100%100%100%100%
   dashboard_viewmodel.dart84.87%100%100%84.87%215–216, 230–234, 236, 245–246, 288, 417, 433–435, 437, 442–443, 500–501, 506, 508, 510, 512, 514, 517–518, 520, 523, 525, 527–528, 530–531, 534–535
   news_viewmodel.dart84.21%100%100%84.21%47, 72, 75
   grades_details_viewmodel.dart100%100%100%100%
   more_viewmodel.dart80.49%100%100%80.49%109–111, 113–114, 116, 121–122
   schedule_viewmodel.dart88.95%100%100%88.95%104–108, 123, 249, 254–255, 290, 333–337, 346–347, 395–396
   schedule_settings_viewmodel.dart69.23%100%100%69.23%101–105, 112–116, 132, 134, 136, 139, 142, 144–145, 70, 72–77
   login_viewmodel.dart100%100%100%100%
   startup_viewmodel.dart92.50%100%100%92.50%107, 142–143
   profile_viewmodel.dart88.57%100%100%88.57%41, 44, 90–91
   choose_language_viewmodel.dart100%100%100%100%
   settings_viewmodel.dart100%100%100%100%
   feedback_viewmodel.dart79.41%100%100%79.41%65–66, 68–70, 72–73
   not_found_viewmodel.dart100%100%100%100%
   web_link_card_viewmodel.dart100%100%100%100%
   emergency_viewmodel.dart7.69%100%100%7.69%17–18, 20–21, 23–25, 29, 31–32, 39–40
   security_viewmodel.dart50%100%100%50%37–38, 42–44, 46, 51–52
   quick_links_viewmodel.dart100%100%100%100%
lib/ui/utils
   discovery_components.dart92.89%100%100%92.89%108, 139, 170, 200, 230, 441, 448–449, 451, 453–458, 46, 77
   app_theme.dart0%100%100%0%5, 71–73, 76–81, 85–87, 93–98
   loading.dart100%100%100%100%
lib/ui/views
   more_view.dart84.35%100%100%84.35%116–118, 188–189, 191, 195, 227–229, 231, 233–235, 50–51, 70–71
   choose_language_view.dart94.59%100%100%94.59%36–37
   login_view.dart82.18%100%100%82.18%125–127, 154, 156, 158–160, 163, 169, 179, 238–239, 241–242, 63–65
   about_view.dart71.64%100%100%71.64%129–130, 136–137, 143–144, 150–151, 157–158, 164–165, 170, 173, 175, 23–25, 92
   grades_view.dart96.36%100%100%96.36%135, 52
   dashboard_view.dart82.76%100%100%82.76%101, 167–169, 177–179, 187–189, 197–199, 237–240, 254–256, 272, 274–275, 293–296, 300–302, 328–329, 379–380, 552
   grade_details_view.dart95.68%100%100%95.68%103, 145, 310, 70, 72–73, 78
   settings_view.dart100%100%100%100%
   feedback_view.dart70.51%100%100%70.51%107, 110–111, 113–117, 119, 124, 128, 130–132, 135–138, 140, 149–151, 158–164, 277–278, 327–329, 331, 333, 335, 337, 41–42, 44–45, 69–70, 72–73
   security_view.dart75.41%100%100%75.41%110, 112–116, 47–49, 68–73
   emergency_view.dart52.17%100%100%52.17%34–40, 51–54
   schedule_view.dart53.52%100%100%53.52%103,

@Udito3 Udito3 merged commit 0f3f097 into hello/master Sep 17, 2023
@Udito3 Udito3 deleted the feature/news_card branch September 17, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants