Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement edge to edge on android #1086

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Conversation

LouisPhilippeHeon
Copy link
Contributor

@LouisPhilippeHeon LouisPhilippeHeon commented Nov 11, 2024

⁉️ Related Issue

Closes #1064

📖 Description

Faire en sorte que la handle au base de l'écran ait un background transparent
En paysage, ne pas afficher la barre de statut.

🧪 How Has This Been Tested?

Tested on android, light and dark mode, landscape and portrait.

☑️ Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • If needed, I added analytics.
  • Make sure to add either one of the following labels: version: Major,version: Minor or version: Patch.

🖼️ Screenshots (if useful):

Capture d’écran, le 2024-11-10 à 23 55 18 Capture d’écran, le 2024-11-10 à 23 51 43

@LouisPhilippeHeon LouisPhilippeHeon self-assigned this Nov 11, 2024
@LouisPhilippeHeon LouisPhilippeHeon requested a review from a team as a code owner November 11, 2024 04:55
lib/main.dart Outdated Show resolved Hide resolved
EffBureau
EffBureau previously approved these changes Nov 12, 2024
Copy link
Contributor

@EffBureau EffBureau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤓

Copy link

Copy link

Coverage after merging feature/edge-to-edge into master will be

71.60%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib/constants
   preferences_flags.dart0%100%100%0%39, 44, 46, 48–50, 53, 55–58, 60, 62
   markers.dart100%100%100%100%
lib/features/app/analytics
   analytics_service.dart0%100%100%0%13–14, 17, 20–22, 25, 30, 32–34, 38, 40–41, 43
   remote_config_service.dart0%100%100%0%101–103, 106–108, 111–113, 116–118, 121–123, 126–128, 131–133, 136–138, 141–143, 146–148, 151–152, 154–158, 162–164, 61–63, 66–68, 71–73, 76–78, 81–83, 86–88, 91–93, 96–98
lib/features/app/error
   internal_info_service.dart0%100%100%0%18–21, 24–29, 32, 34–38, 42–43
lib/features/app/error/not_found
   not_found_viewmodel.dart100%100%100%100%
   not_found_view.dart92.59%100%100%92.59%69–70
lib/features/app/integration
   github_api.dart0%100%100%0%101, 103–107, 109–110, 113, 115, 122–125, 129–130, 132, 36–38, 42–46, 48–49, 51, 53, 55–56, 59, 61, 68, 73–79, 83, 85, 87–89, 91–92, 95, 97
   launch_url_service.dart0%100%100%0%16–18, 21–23, 26–31, 37, 55–56, 59
   networking_service.dart0%100%100%0%10–11, 13–15, 18–20
lib/features/app/monets_api
   monets_api_client.dart90.91%100%100%90.91%22
lib/features/app/monets_api/models
   mon_ets_user.dart50%100%100%50%29–33, 35, 37
lib/features/app/navigation
   navigation_service.dart0%100%100%0%100, 31, 34–35, 37–38, 45–46, 49–50, 53–55, 57, 62–63, 66–67, 70–72, 75–76, 79, 81, 86, 89, 91–92, 95–97, 99
   navigation_history_observer.dart0%100%100%0%12–14, 16, 18, 20, 23, 25, 28, 30, 8–9
lib/features/app/repository
   author_repository.dart0%100%100%0%13, 15
   course_repository.dart84.34%100%100%84.34%200, 205, 210–211, 213, 217, 219–220, 223–229, 234, 236, 239, 241–243, 246–251, 255, 259–261, 263, 267, 337, 345, 347, 532–533, 83
   news_repository.dart0%100%100%0%16, 21
   quick_link_repository.dart85.71%100%100%85.71%39–40
   user_repository.dart93.52%100%100%93.52%135–136, 186, 308, 310, 98–99
lib/features/app/signets-api
   signets_api_client.dart88.89%100%100%88.89%35, 45, 47, 49
   soap_service.dart100%100%100%100%
lib/features/app/signets-api/commands
   authentificate_command.dart0%100%100%0%18, 21, 24–28, 31
   get_course_reviews_command.dart100%100%100%100%
   get_course_summary_command.dart100%100%100%100%
   get_courses_activities_command.dart100%100%100%100%
   get_courses_command.dart100%100%100%100%
   get_programs_command.dart100%100%100%100%
   get_schedule_activities_command.dart100%100%100%100%
   get_sessions_command.dart100%100%100%100%
   get_student_info_command.dart100%100%100%100%
lib/features/app/signets-api/models
   course.dart80.52%100%100%80.52%102–105, 120, 122–131
   course_activity.dart81.40%100%100%81.40%83, 85–91
   schedule_activity.dart80.95%100%100%80.95%121, 123–133
   session.dart73.08%100%100%73.08%159, 161–173, 175, 177–189
   profile_student.dart82.14%100%100%82.14%56, 58–61
   program.dart81.13%100%100%81.13%100–106, 96, 98–99
   course_review.dart51.92%100%100%51.92%100–103, 51–58, 70, 72–79, 95, 97–99
   course_summary.dart86.84%100%100%86.84%106, 108–116
   course_evaluation.dart70.54%100%100%70.54%128, 167, 169–182, 184, 186–200, 49
lib/features/app/startup
   startup_viewmodel.dart76.92%100%100%76.92%37–38, 54
lib/features/app/storage
   cache_manager.dart0%100%100%0%30–31, 34–37, 40, 44, 46–50, 56, 58–61, 66, 68–71
   preferences_service.dart63.64%100%100%63.64%112–113, 115, 29, 31, 33, 36–38, 51, 60–63, 73–75, 78, 80–81
lib/features/app/widgets
   base_scaffold.dart85.71%100%100%85.71%106, 140, 169–170, 172–174, 176–177, 179–180
   bottom_bar.dart91.07%100%100%91.07%48, 50, 52, 57, 61
   navigation_rail.dart56.36%100%100%56.36%39, 49, 51, 53, 56, 60, 66–67, 72–86, 88
   dismissible_card.dart100%100%100%100%
   link_web_view.dart88.24%100%100%88.24%38–39
lib/features/dashboard
   dashboard_view.dart65.84%100%100%65.84%146–149, 157–160, 168–170, 178–180, 188–190, 230–233, 247–249, 255–257, 266, 268–269, 287–290, 294–296, 314–315, 321–322, 347–348, 387, 394, 416–417, 452–455, 458–462, 464, 466, 468, 470–473, 475–478, 481, 483–484, 491–492, 497, 499, 505, 511–514, 542–543, 77, 88
   dashboard_viewmodel.dart92.96%100%100%92.96%137–139, 141, 144, 195, 198, 270, 316, 320, 359, 364, 402, 465–466
lib/features/dashboard/widgets
   course_activity_tile.dart100%100%100%100%
   haptics_container.dart100%100%100%100%
lib/features/ets
   ets_view.dart80.65%100%100%80.65%29–31, 81–83
lib/features/ets/events/api-client
   hello_api_client.dart91.67%100%100%91.67%26
lib/features/ets/events/api-client/commands
   get_events_command.dart74.07%100%100%74.07%50, 58, 61, 64, 67, 70, 73
   get_organizer_command.dart92.31%100%100%92.31%26
   report_news_command.dart92.86%100%100%92.86%27
lib/features/ets/events/api-client/models
   organizer.dart100%100%100%100%
   paginated_news.dart31.03%100%100%31.03%36–41, 44, 47–53, 55, 57–61
   report.dart14.29%100%100%14.29%15–17, 20–22
   activity_area.dart48.15%100%100%48.15%35, 38–44,

@XavierPaquet-Rapold XavierPaquet-Rapold merged commit 88d2341 into master Nov 12, 2024
7 checks passed
@XavierPaquet-Rapold XavierPaquet-Rapold deleted the feature/edge-to-edge branch November 12, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edge-to-edge
3 participants