Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace auto size text #1084

Merged
merged 13 commits into from
Nov 24, 2024
Merged

Replace auto size text #1084

merged 13 commits into from
Nov 24, 2024

Conversation

NakanLuca
Copy link
Contributor

@NakanLuca NakanLuca commented Nov 10, 2024

⁉️ Related Issue

Closes #1070 : remove auto_size_text

📖 Description

I completely removed the auto_size_text dependency from the project and replaced it's calls by 'Text'.

🧪 How Has This Been Tested?

I compared the front end where auto_size_text was used before and after removing it on a mobile phone and a tablet.
I saw no changes.

☑️ Checklist before requesting a review

  • I have performed a self-review of my code.
  • Make sure to add either one of the following labels: version: Major,version: Minor or version: Patch.

@NakanLuca NakanLuca requested a review from a team as a code owner November 10, 2024 23:02
@LouisPhilippeHeon LouisPhilippeHeon changed the title Feature/1070 replace auto size text Replace auto size text Nov 11, 2024
pubspec.yaml Outdated Show resolved Hide resolved
@github-actions github-actions bot added size: S and removed size: XS labels Nov 24, 2024
@github-actions github-actions bot added size: XS and removed size: S labels Nov 24, 2024
Copy link

Coverage after merging feature/1070_replace_auto-size-text into master will be

72.55%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib/constants
   preferences_flags.dart0%100%100%0%39, 44, 46, 48–50, 53, 55–58, 60, 62
   markers.dart100%100%100%100%
lib/features/app/analytics
   analytics_service.dart0%100%100%0%13–14, 17, 20–22, 25, 30, 32–34, 38, 40–41, 43
   remote_config_service.dart0%100%100%0%100–101, 104–106, 109–111, 114–116, 119–121, 124–126, 129–131, 134–136, 139–141, 144–145, 147–151, 155–157, 59–61, 64–66, 69–71, 74–76, 79–81, 84–86, 89–91, 94–96, 99
lib/features/app/error
   internal_info_service.dart0%100%100%0%18–21, 24–29, 32, 34–38, 42–43
lib/features/app/error/not_found
   not_found_viewmodel.dart100%100%100%100%
   not_found_view.dart92.59%100%100%92.59%69–70
lib/features/app/integration
   launch_url_service.dart0%100%100%0%16–19, 21, 25–28, 30, 34–37
   networking_service.dart0%100%100%0%10–11, 13–15, 18–20
lib/features/app/monets_api
   monets_api_client.dart90.91%100%100%90.91%22
lib/features/app/monets_api/models
   mon_ets_user.dart50%100%100%50%29–33, 35, 37
lib/features/app/navigation
   navigation_service.dart0%100%100%0%100, 31, 34–35, 37–38, 45–46, 49–50, 53–55, 57, 62–63, 66–67, 70–72, 75–76, 79, 81, 86, 89, 91–92, 95–97, 99
   navigation_history_observer.dart0%100%100%0%12–14, 16, 18, 20, 23, 25, 28, 30, 8–9
lib/features/app/repository
   author_repository.dart0%100%100%0%13, 15
   course_repository.dart84.34%100%100%84.34%200, 205, 210–211, 213, 217, 219–220, 223–229, 234, 236, 239, 241–243, 246–251, 255, 259–261, 263, 267, 337, 345, 347, 532–533, 83
   news_repository.dart0%100%100%0%16, 21
   quick_link_repository.dart85.71%100%100%85.71%39–40
   user_repository.dart93.52%100%100%93.52%135–136, 186, 308, 310, 98–99
lib/features/app/signets-api
   signets_api_client.dart88.89%100%100%88.89%35, 45, 47, 49
   soap_service.dart100%100%100%100%
lib/features/app/signets-api/commands
   authentificate_command.dart0%100%100%0%18, 21, 24–28, 31
   get_course_reviews_command.dart100%100%100%100%
   get_course_summary_command.dart100%100%100%100%
   get_courses_activities_command.dart100%100%100%100%
   get_courses_command.dart100%100%100%100%
   get_programs_command.dart100%100%100%100%
   get_schedule_activities_command.dart100%100%100%100%
   get_sessions_command.dart100%100%100%100%
   get_student_info_command.dart100%100%100%100%
lib/features/app/signets-api/models
   course.dart80.52%100%100%80.52%102–105, 120, 122–131
   course_activity.dart81.40%100%100%81.40%83, 85–91
   schedule_activity.dart80.95%100%100%80.95%121, 123–133
   session.dart73.08%100%100%73.08%159, 161–173, 175, 177–189
   profile_student.dart82.14%100%100%82.14%56, 58–61
   program.dart81.13%100%100%81.13%100–106, 96, 98–99
   course_review.dart51.92%100%100%51.92%100–103, 51–58, 70, 72–79, 95, 97–99
   course_summary.dart86.84%100%100%86.84%106, 108–116
   course_evaluation.dart70.54%100%100%70.54%128, 167, 169–182, 184, 186–200, 49
lib/features/app/startup
   startup_viewmodel.dart76.92%100%100%76.92%37–38, 54
lib/features/app/storage
   cache_manager.dart0%100%100%0%30–31, 34–37, 40, 44, 46–50, 56, 58–61, 66, 68–71
   preferences_service.dart63.64%100%100%63.64%112–113, 115, 29, 31, 33, 36–38, 51, 60–63, 73–75, 78, 80–81
lib/features/app/widgets
   base_scaffold.dart85.71%100%100%85.71%106, 140, 169–170, 172–174, 176–177, 179–180
   dismissible_card.dart100%100%100%100%
lib/features/app/widgets/navigation
   bottom_bar.dart100%100%100%100%
   navigation_rail.dart88.89%100%100%88.89%15
   base_navigation_bar.dart100%100%100%100%
lib/features/dashboard
   dashboard_view.dart66.39%100%100%66.39%146–148, 156–158, 166–168, 176–178, 186–188, 228–231, 245–247, 253–255, 264, 266–267, 285–288, 292–294, 312–313, 319–320, 345–346, 385, 392, 414–415, 450–453, 456–460, 462, 464, 466, 468–471, 473–476, 479, 481–482, 489–490, 495, 497, 503, 509–512, 540–541, 77, 88
   dashboard_viewmodel.dart93.84%100%100%93.84%132–134, 184, 187, 259, 305, 309, 348, 353, 391, 454–455
lib/features/dashboard/widgets
   course_activity_tile.dart100%100%100%100%
   haptics_container.dart100%100%100%100%
lib/features/ets
   ets_view.dart80.65%100%100%80.65%29–31, 81–83
lib/features/ets/events/api-client
   hello_api_client.dart91.67%100%100%91.67%26
lib/features/ets/events/api-client/commands
   get_events_command.dart74.07%100%100%74.07%50, 58, 61, 64, 67, 70, 73
   get_organizer_command.dart92.31%100%100%92.31%26
   report_news_command.dart92.86%100%100%92.86%27
lib/features/ets/events/api-client/models
   organizer.dart100%100%100%100%
   paginated_news.dart31.03%100%100%31.03%36–41, 44, 47–53, 55, 57–61
   report.dart14.29%100%100%14.29%15–17, 20–22
   activity_area.dart48.15%100%100%48.15%35, 38–44, 46, 48–52
   news.dart50.88%100%100%50.88%100–101, 103, 105–116, 85, 88–99
   news_tags.dart5%100%100%5%17–21, 23–27, 30, 33–38, 40, 42
lib/features/ets/events/author
   author_view.dart79.37%100%100%79.37%109, 157, 231, 278–281, 283–284, 352–354, 356–357, 359–360, 364–365, 370, 374–375, 382–385, 387, 44–47, 49–52, 62–63, 93, 96–97
   author_info_skeleton.dart97.67%100%100%97.67%78
   

@NakanLuca NakanLuca merged commit d89e32b into master Nov 24, 2024
7 checks passed
@NakanLuca NakanLuca deleted the feature/1070_replace_auto-size-text branch November 24, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove auto_size_text
3 participants