-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/refactor login view #1083
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spoodern0t
added
feature: auth
Issue concerning the authentication of the application.
version: Minor
labels
Nov 10, 2024
LouisPhilippeHeon
requested changes
Nov 10, 2024
XavierPaquet-Rapold
requested changes
Nov 10, 2024
…ETS/Notre-Dame into feature/refactor-login_view
XavierPaquet-Rapold
previously approved these changes
Nov 10, 2024
Quality Gate passedIssues Measures |
LouisPhilippeHeon
approved these changes
Nov 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
XavierPaquet-Rapold
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1082
📖 Description
Moved several widgets from login_view.dart to their own files in order to increase legibility.
Said new files are located at features/welcome/widgets
🧪 How Has This Been Tested?
This was tested by trying multiple login attempts (valid and invalid) and making sure that each widget responded the way it did before the change.
The change does not affect any classes or files beyond login_view.dart, and the core function of the moved widgets was left intact.
☑️ Checklist before requesting a review
version: Major
,version: Minor
orversion: Patch
.🖼️ Screenshots (if useful):