-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/1068 replace flutter siren 2 #1073
Feature/1068 replace flutter siren 2 #1073
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
commit 20d01cb Author: Louis-Philippe Héon <[email protected]> Date: Mon Nov 4 20:25:25 2024 -0500 Automatically show weekend days (#1048) * Fixes to Today Button, custom settings window for calendar view, labo groups support * Add setting for showing saturday/sunday/none * Change event loading logic to fix missing events * Add indicator in week line for today * Change event string layout and fix current day indicator bug * [BOT] Bump version from 4.21.0+1 to 4.21.1+1 * Fix tests * Fix tests and enum * Fix livetime line color for dark/light mode * [BOT] Bump version from 4.21.1+1 to 4.21.2+1 * [BOT] Update golden files * [BOT] Update golden files * month_view v1 * Fix bug & Done - Calendar month view * Add tests * [BOT] Applying version. * Bug fixes on tests * Code cleaning for the month view * [BOT] Applying version. * Add day view for calendar * Make the CircularProgressIndicator fit in the bottomsheet * Fix a bug where when we change the calendar view, no calendar format is chosen * Show saturday automatically * Remove setting flag * [BOT] Applying version. * Remove unused imports * Add unit tests * Increase coverage * Add sunday * Make more readable * Fix selected date when changing from list view to week view * fix typo * Remove dead code * Remove two weeks from settings when in calendar mode * Fix #1049 * Make sunday first day of the week and remove variables from loop * Fix bug related to changing first day of the week to sunday * typo * Another sunday related fix * Forgot to commit that * Add tests for calendar view * [BOT] Applying version. * Mega cleanup * Removed unused things * Update comments * Tests won't pass but it's ok :( * Fix errors * Fix errors * Fix tests * More tests * Refactor handle view changed * Fix small issues * Add tests * fix tests * Remove unused imports * Fix on light theme * smoother swipe day view * Avoid fetching more events than necessary * Tiny fix, only load days necessary * Small tweaks * Update comment * dsfgkyjsrkekwtjery gvruteiwFGQRI7TUTYRE4GYIUT4EW * Fix bug David found * Fix problem found by David * Display month in day chips (day view) --------- Co-authored-by: Hugo Migner <[email protected]> Co-authored-by: HugoMigner <[email protected]> Co-authored-by: Samuel Montambault <[email protected]> Co-authored-by: MysticFragilist <[email protected]> Co-authored-by: DavidMartel12 <[email protected]> Co-authored-by: DavidMartel12 <[email protected]> Co-authored-by: DavidMartel12 <[email protected]> Co-authored-by: LouisPhilippeHeon <[email protected]>
a475f90
to
e8579e7
Compare
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤓
closes: #1068
closes: #1067
📖 Description
🧪 How Has This Been Tested?
☑️ Checklist before requesting a review
version: Major
,version: Minor
orversion: Patch
.🖼️ Screenshots (if useful):