Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1068 replace flutter siren 2 #1073

Merged
merged 19 commits into from
Nov 8, 2024

Conversation

XavierPaquet-Rapold
Copy link
Contributor

@XavierPaquet-Rapold XavierPaquet-Rapold commented Oct 25, 2024

⁉️ Related Issue

closes: #1068
closes: #1067

📖 Description

  • Remove alert for new version
  • Remove tutorial
  • Update dependency versions

🧪 How Has This Been Tested?

  • On device + run unit test

☑️ Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • If needed, I added analytics.
  • Make sure to add either one of the following labels: version: Major,version: Minor or version: Patch.

🖼️ Screenshots (if useful):

@XavierPaquet-Rapold XavierPaquet-Rapold marked this pull request as ready for review October 26, 2024 02:29
@XavierPaquet-Rapold XavierPaquet-Rapold requested a review from a team as a code owner October 26, 2024 02:29
Copy link
Contributor

@LouisPhilippeHeon LouisPhilippeHeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XavierPaquet-Rapold and others added 16 commits November 8, 2024 09:25
commit 20d01cb
Author: Louis-Philippe Héon <[email protected]>
Date:   Mon Nov 4 20:25:25 2024 -0500

    Automatically show weekend days (#1048)

    * Fixes to Today Button, custom settings window for calendar view, labo groups support

    * Add setting for showing saturday/sunday/none

    * Change event loading logic to fix missing events

    * Add indicator in week line for today

    * Change event string layout and fix current day indicator bug

    * [BOT] Bump version from 4.21.0+1 to 4.21.1+1

    * Fix tests

    * Fix tests and enum

    * Fix livetime line color for dark/light mode

    * [BOT] Bump version from 4.21.1+1 to 4.21.2+1

    * [BOT] Update golden files

    * [BOT] Update golden files

    * month_view v1

    * Fix bug & Done - Calendar month view

    * Add tests

    * [BOT] Applying version.

    * Bug fixes on tests

    * Code cleaning for the month view

    * [BOT] Applying version.

    * Add day view for calendar

    * Make the CircularProgressIndicator fit in the bottomsheet

    * Fix a bug where when we change the calendar view, no calendar format is chosen

    * Show saturday automatically

    * Remove setting flag

    * [BOT] Applying version.

    * Remove unused imports

    * Add unit tests

    * Increase coverage

    * Add sunday

    * Make more readable

    * Fix selected date when changing from list view to week view

    * fix typo

    * Remove dead code

    * Remove two weeks from settings when in calendar mode

    * Fix #1049

    * Make sunday first day of the week and remove variables from loop

    * Fix bug related to changing first day of the week to sunday

    * typo

    * Another sunday related fix

    * Forgot to commit that

    * Add tests for calendar view

    * [BOT] Applying version.

    * Mega cleanup

    * Removed unused things

    * Update comments

    * Tests won't pass but it's ok :(

    * Fix errors

    * Fix errors

    * Fix tests

    * More tests

    * Refactor handle view changed

    * Fix small issues

    * Add tests

    * fix tests

    * Remove unused imports

    * Fix on light theme

    * smoother swipe day view

    * Avoid fetching more events than necessary

    * Tiny fix, only load days necessary

    * Small tweaks

    * Update comment

    * dsfgkyjsrkekwtjery gvruteiwFGQRI7TUTYRE4GYIUT4EW

    * Fix bug David found

    * Fix problem found by David

    * Display month in day chips (day view)

    ---------

    Co-authored-by: Hugo Migner <[email protected]>
    Co-authored-by: HugoMigner <[email protected]>
    Co-authored-by: Samuel Montambault <[email protected]>
    Co-authored-by: MysticFragilist <[email protected]>
    Co-authored-by: DavidMartel12 <[email protected]>
    Co-authored-by: DavidMartel12 <[email protected]>
    Co-authored-by: DavidMartel12 <[email protected]>
    Co-authored-by: LouisPhilippeHeon <[email protected]>
@XavierPaquet-Rapold XavierPaquet-Rapold force-pushed the feature/1068-replace-flutter-siren-2 branch from a475f90 to e8579e7 Compare November 8, 2024 14:33
Copy link

github-actions bot commented Nov 8, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

sonarqubecloud bot commented Nov 8, 2024

Copy link

github-actions bot commented Nov 8, 2024

Coverage after merging feature/1068-replace-flutter-siren-2 into master will be

71.41%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib/constants
   preferences_flags.dart0%100%100%0%42, 47, 49, 51–53, 56, 58–61, 63, 65
   markers.dart100%100%100%100%
lib/features/app/analytics
   analytics_service.dart0%100%100%0%13–14, 17, 20–22, 25, 30, 32–34, 38, 40–41, 43
   remote_config_service.dart0%100%100%0%100, 103–105, 108–110, 113–115, 118–120, 123–125, 128–130, 133–135, 138–140, 143–144, 146–150, 154–156, 58–60, 63–65, 68–70, 73–75, 78–80, 83–85, 88–90, 93–95, 98–99
lib/features/app/error
   internal_info_service.dart0%100%100%0%18–21, 24–29, 32, 34–38, 42–43
lib/features/app/error/not_found
   not_found_viewmodel.dart100%100%100%100%
   not_found_view.dart92.59%100%100%92.59%69–70
lib/features/app/integration
   github_api.dart0%100%100%0%100–101, 104, 106, 110, 112–116, 118–119, 122, 124, 131–134, 138–139, 141, 39, 42–43, 47, 51–55, 57–58, 60, 62, 64–65, 68, 70, 77, 82–88, 92, 94, 96–98
   launch_url_service.dart0%100%100%0%16–18, 21–23, 26–31, 37, 55–56, 59
   networking_service.dart0%100%100%0%10–11, 13–15, 18–20
lib/features/app/monets_api
   monets_api_client.dart90.91%100%100%90.91%22
lib/features/app/monets_api/models
   mon_ets_user.dart50%100%100%50%29–33, 35, 37
lib/features/app/navigation
   navigation_service.dart0%100%100%0%100, 31, 34–35, 37–38, 45–46, 49–50, 53–55, 57, 62–63, 66–67, 70–72, 75–76, 79, 81, 86, 89, 91–92, 95–97, 99
   navigation_history_observer.dart0%100%100%0%12–14, 16, 18, 20, 23, 25, 28, 30, 8–9
lib/features/app/repository
   author_repository.dart0%100%100%0%13, 15
   course_repository.dart84.34%100%100%84.34%200, 205, 210–211, 213, 217, 219–220, 223–229, 234, 236, 239, 241–243, 246–251, 255, 259–261, 263, 267, 337, 345, 347, 532–533, 83
   news_repository.dart0%100%100%0%16, 21
   quick_link_repository.dart85.71%100%100%85.71%39–40
   user_repository.dart93.52%100%100%93.52%135–136, 186, 308, 310, 98–99
lib/features/app/signets-api
   signets_api_client.dart88.89%100%100%88.89%35, 45, 47, 49
   soap_service.dart100%100%100%100%
lib/features/app/signets-api/commands
   authentificate_command.dart0%100%100%0%18, 21, 24–28, 31
   get_course_reviews_command.dart100%100%100%100%
   get_course_summary_command.dart100%100%100%100%
   get_courses_activities_command.dart100%100%100%100%
   get_courses_command.dart100%100%100%100%
   get_programs_command.dart100%100%100%100%
   get_schedule_activities_command.dart100%100%100%100%
   get_sessions_command.dart100%100%100%100%
   get_student_info_command.dart100%100%100%100%
lib/features/app/signets-api/models
   course.dart80.52%100%100%80.52%102–105, 120, 122–131
   course_activity.dart81.40%100%100%81.40%83, 85–91
   schedule_activity.dart80.95%100%100%80.95%121, 123–133
   session.dart73.08%100%100%73.08%159, 161–173, 175, 177–189
   profile_student.dart82.14%100%100%82.14%56, 58–61
   program.dart81.13%100%100%81.13%100–106, 96, 98–99
   course_review.dart51.92%100%100%51.92%100–103, 51–58, 70, 72–79, 95, 97–99
   course_summary.dart86.84%100%100%86.84%106, 108–116
   course_evaluation.dart70.54%100%100%70.54%128, 167, 169–182, 184, 186–200, 49
lib/features/app/startup
   startup_viewmodel.dart76.92%100%100%76.92%37–38, 54
lib/features/app/storage
   cache_manager.dart0%100%100%0%30–31, 34–37, 40, 44, 46–50, 56, 58–61, 66, 68–71
   preferences_service.dart63.64%100%100%63.64%112–113, 115, 29, 31, 33, 36–38, 51, 60–63, 73–75, 78, 80–81
lib/features/app/widgets
   base_scaffold.dart85.33%100%100%85.33%105, 135, 164–165, 167–169, 171–172, 174–175
   bottom_bar.dart90.91%100%100%90.91%46, 48, 50, 55, 59
   navigation_rail.dart55.56%100%100%55.56%37, 47, 49, 51, 54, 58, 64–65, 70–84, 86
   dismissible_card.dart100%100%100%100%
   link_web_view.dart88.24%100%100%88.24%38–39
lib/features/dashboard
   dashboard_view.dart65.84%100%100%65.84%146–149, 157–160, 168–170, 178–180, 188–190, 230–233, 247–249, 255–257, 266, 268–269, 287–290, 294–296, 314–315, 321–322, 347–348, 387, 394, 416–417, 452–455, 458–462, 464, 466, 468, 470–473, 475–478, 481, 483–484, 491–492, 497, 499, 505, 511–514, 542–543, 77, 88
   dashboard_viewmodel.dart92.96%100%100%92.96%137–139, 141, 144, 195, 198, 270, 316, 320, 359, 364, 402, 465–466
lib/features/dashboard/widgets
   course_activity_tile.dart100%100%100%100%
   haptics_container.dart100%100%100%100%
lib/features/ets
   ets_view.dart80%100%100%80%27–29, 79–81
lib/features/ets/events/api-client
   hello_api_client.dart91.67%100%100%91.67%26
lib/features/ets/events/api-client/commands
   get_events_command.dart74.07%100%100%74.07%50, 58, 61, 64, 67, 70, 73
   get_organizer_command.dart92.31%100%100%92.31%26
   report_news_command.dart92.86%100%100%92.86%27
lib/features/ets/events/api-client/models
   organizer.dart100%100%100%100%
   paginated_news.dart31.03%100%100%31.03%36–41, 44, 47–53, 55, 57–61
   report.dart14.29%100%100%14.29%15–17, 20–22
   activity_area.dart48.15%100%100%48.15%

Copy link
Contributor

@EffBureau EffBureau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤓

@XavierPaquet-Rapold XavierPaquet-Rapold merged commit cb8c337 into master Nov 8, 2024
7 checks passed
@XavierPaquet-Rapold XavierPaquet-Rapold deleted the feature/1068-replace-flutter-siren-2 branch November 8, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace flutter_siren_2 with upgrader (priority) Remove feature discovery
3 participants