Bugfix/1026 Android back gesture should follow navigation history #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouisPhilippeHeon
requested changes
Sep 24, 2024
Bonne idée, ça ne devrait pas être trop compliqué à intégrer. Je vais checker ça. |
EffBureau
reviewed
Sep 25, 2024
|
XavierPaquet-Rapold
approved these changes
Oct 27, 2024
LouisPhilippeHeon
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1026
📖 Description
This PR addresses the navigation issue on Android where the back button and back gesture navigation were not functioning as expected. Previously, these actions would always return the user to the dashboard, regardless of the navigation history. This fix ensures that the user is returned to the previous screen in their navigation stack. The back button should always take you back to the screen you were just on.
Also, this PR eliminates duplicate routes in the navigation history. This means that if users spam two tabs repeatedly, they will not need to click the back button multiple times to go back to previous routes (see the 2nd video below for a demo).
🧪 How Has This Been Tested?
☑️ Checklist before requesting a review
version: Major,version: Minororversion: Patch.🖼️ Screenshots (if useful):
Back button navigation demo:
demo_back_button_nav.mp4
Navigation when user clicks same tabs multiple times:
demo_dupe_back_button_nav.mp4
Navigation with back gesture:
demo_back_gesture_nav.mp4