Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/day view calendar #1054

Closed
wants to merge 36 commits into from
Closed

Feature/day view calendar #1054

wants to merge 36 commits into from

Conversation

DavidMartel12
Copy link
Contributor

⁉️ Related Issue

#779

📖 Description

Add day feature for calendar view, tests, loading view between each calendar type and new date template for each calendar type:

  • Calendar view : Day, Week, Month
  • Table view : Week, 2 Week, Month

🧪 How Has This Been Tested?

I added tests to make sure that when we change the calendar type, the correct one is displayed and depending on the calendar type displayed, I added tests to make sure it is the correct date pattern.

☑️ Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • If needed, I added analytics.
  • Make sure to add either one of the following labels: version: Major,version: Minor or version: Patch.

🖼️ Screenshots (if useful):

image

HugoMigner and others added 30 commits February 21, 2023 10:47
@HugoMigner
Fixes to Today Button, custom settings window for calendar view, labo…
86f4b07 
… groups support
@HugoMigner
Add setting for showing saturday/sunday/none
2436873
@HugoMigner
Change event loading logic to fix missing events
6b2c2cf
@HugoMigner
Add indicator in week line for today
9826185
@HugoMigner
Change event string layout and fix current day indicator bug
00e1977
@HugoMigner @github-actions
[BOT] Bump version from 4.21.0+1 to 4.21.1+1
f382d08
@HugoMigner
Fix tests
1a402d0
@HugoMigner
Fix tests and enum
732da4a
@HugoMigner
Fix livetime line color for dark/light mode
2a178fd
@HugoMigner @github-actions
[BOT] Bump version from 4.21.1+1 to 4.21.2+1
8299ce6
@HugoMigner @github-actions
[BOT] Update golden files
f93ef70
@MysticFragilist
Merge branch 'master' into bugfix/calendar-view-settings
7186fc2
@MysticFragilist @github-actions
[BOT] Update golden files
d67e090
month_view v1
418352e
Fix bug & Done - Calendar month view
cfd7ffa
Add tests
b81658d
@DavidMartel12
Merge branch 'master' into feature/month-view-calendar
bf48488
@DavidMartel12 @github-actions
[BOT] Applying version.
f3846ba
@DavidMartel12
Bug fixes on tests
dfc1a9d
@DavidMartel12
Merge branch 'feature/month-view-calendar' of https://github.com/Appl…
f356849 
…ETS/Notre-Dame into feature/month-view-calendar
@DavidMartel12
Code cleaning for the month view
dd137cb
@DavidMartel12
Merge branch 'master' into feature/month-view-calendar
be685d7
@DavidMartel12 @github-actions
[BOT] Applying version.
ea72f59
@DavidMartel12
Merge branch 'master' into feature/day-view-calendar
c31fc24
@DavidMartel12
Merge branch 'master' into feature/day-view-calendar
9382267
@DavidMartel12
Add day view for calendar
023fd7e
@DavidMartel12
Make the CircularProgressIndicator fit in the bottomsheet
23ac77c
@DavidMartel12
Merge branch 'master' into feature/day-view-calendar
912b294
@DavidMartel12
Fix a bug where when we change the calendar view, no calendar format …
9bad438 
…is chosen
@DavidMartel12
Add tests for calendar view
451bc1a
@DavidMartel12 DavidMartel12 added feature: Schedule Issue concerning the schedule section of the application version: Minor labels Sep 16, 2024
@DavidMartel12 DavidMartel12 requested a review from a team as a code owner September 16, 2024 21:29
LouisPhilippeHeon
LouisPhilippeHeon requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@LouisPhilippeHeon LouisPhilippeHeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est ce que ce serait possible de mettre la journée de la semaine dans la date au haut de la page s'il te plait?

LouisPhilippeHeon
LouisPhilippeHeon approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@LouisPhilippeHeon LouisPhilippeHeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Les changements que j'avais demandé précédemment seront fait dans #1048

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Coverage after merging feature/day-view-calendar into master will be

72.29%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib/constants
   preferences_flags.dart0%100%100%0%59, 64, 66, 68–70, 73, 75–78, 80, 82
   markers.dart100%100%100%100%
lib/features/app/analytics
   analytics_service.dart0%100%100%0%13–14, 17, 20–22, 25, 30, 32–34, 38, 40–41, 43
   remote_config_service.dart0%100%100%0%100, 103–105, 108–110, 113–115, 118–120, 123–125, 128–130, 133–135, 138–140, 143–144, 146–150, 154–156, 58–60, 63–65, 68–70, 73–75, 78–80, 83–85, 88–90, 93–95, 98–99
lib/features/app/error
   internal_info_service.dart0%100%100%0%18–21, 24–29, 32, 34–38, 42–43
lib/features/app/error/not_found
   not_found_viewmodel.dart100%100%100%100%
   not_found_view.dart94.74%100%100%94.74%92–93
lib/features/app/integration
   github_api.dart0%100%100%0%100–101, 104, 106, 110, 112–116, 118–119, 122, 124, 131–134, 138–139, 141, 39, 42–43, 47, 51–55, 57–58, 60, 62, 64–65, 68, 70, 77, 82–88, 92, 94, 96–98
   launch_url_service.dart0%100%100%0%16–18, 21–23, 26–31, 37, 55–56, 59
   networking_service.dart0%100%100%0%10–11, 13–15, 18–20
lib/features/app/monets_api
   monets_api_client.dart90.91%100%100%90.91%22
lib/features/app/monets_api/models
   mon_ets_user.dart50%100%100%50%29–33, 35, 37
lib/features/app/navigation
   navigation_service.dart0%100%100%0%27, 30–31, 33–34, 41–42, 45–46, 49–51, 53, 58, 61, 63–64, 67–69, 71–72
lib/features/app/presentation
   rive_animation_service.dart0%100%100%0%12–13, 16, 19–20, 28, 32–33, 35
lib/features/app/repository
   author_repository.dart0%100%100%0%13, 15
   course_repository.dart84.34%100%100%84.34%200, 205, 210–211, 213, 217, 219–220, 223–229, 234, 236, 239, 241–243, 246–251, 255, 259–261, 263, 267, 337, 345, 347, 532–533, 83
   news_repository.dart0%100%100%0%16, 21
   quick_link_repository.dart85.71%100%100%85.71%39–40
   user_repository.dart93.52%100%100%93.52%135–136, 186, 308, 310, 98–99
lib/features/app/signets-api
   signets_api_client.dart88.89%100%100%88.89%35, 45, 47, 49
   soap_service.dart100%100%100%100%
lib/features/app/signets-api/commands
   authentificate_command.dart0%100%100%0%18, 21, 24–28, 31
   get_course_reviews_command.dart100%100%100%100%
   get_course_summary_command.dart100%100%100%100%
   get_courses_activities_command.dart100%100%100%100%
   get_courses_command.dart100%100%100%100%
   get_programs_command.dart100%100%100%100%
   get_schedule_activities_command.dart100%100%100%100%
   get_sessions_command.dart100%100%100%100%
   get_student_info_command.dart100%100%100%100%
lib/features/app/signets-api/models
   course.dart80.52%100%100%80.52%102–105, 120, 122–131
   course_activity.dart81.40%100%100%81.40%83, 85–91
   schedule_activity.dart80.95%100%100%80.95%121, 123–133
   session.dart73.08%100%100%73.08%159, 161–173, 175, 177–189
   profile_student.dart82.14%100%100%82.14%56, 58–61
   program.dart81.13%100%100%81.13%100–106, 96, 98–99
   course_review.dart51.92%100%100%51.92%100–103, 51–58, 70, 72–79, 95, 97–99
   course_summary.dart86.84%100%100%86.84%106, 108–116
   course_evaluation.dart70.54%100%100%70.54%128, 167, 169–182, 184, 186–200, 49
lib/features/app/startup
   startup_viewmodel.dart92.50%100%100%92.50%103, 138–139
lib/features/app/storage
   cache_manager.dart0%100%100%0%30–31, 34–37, 40, 44, 46–50, 56, 58–61, 66, 68–71
   preferences_service.dart69.09%100%100%69.09%119–120, 122, 36, 38, 40, 43–45, 69–70, 80–82, 85, 87–88
   siren_flutter_service.dart0%100%100%0%13–14, 18–19, 23–25, 29–31, 35, 41
lib/features/app/widgets
   dismissible_card.dart100%100%100%100%
   base_scaffold.dart85.33%100%100%85.33%105, 135, 164–165, 167–169, 171–172, 174–175
   navigation_rail.dart64.18%100%100%64.18%41, 51, 53, 55, 58, 62, 68–69, 74–88, 90
   bottom_bar.dart92.65%100%100%92.65%50, 52, 54, 59, 63
   link_web_view.dart88.24%100%100%88.24%38–39
lib/features/dashboard
   dashboard_view.dart67.19%100%100%67.19%154–157, 165–168, 176–178, 186–188, 196–198, 238–241, 255–257, 263–265, 274, 276–277, 295–298, 302–304, 322–323, 329–330, 355–356, 395, 402, 424–425, 460–463, 466–470, 472, 474, 476, 478–481, 483–486, 489, 491–492, 499–500, 505, 507, 513, 519–522, 550–551, 573, 85, 96
   dashboard_viewmodel.dart83.88%100%100%83.88%145–147, 149, 152, 203, 206, 278, 324, 328, 367, 372, 410, 425, 427–429, 431, 436–437, 493, 498, 500–501, 503–504, 507–508, 510, 513, 515, 517–518, 520–521, 524–525, 537–538
lib/features/dashboard/widgets
   course_activity_tile.dart100%100%100%100%
   haptics_container.dart100%100%100%100%
lib/features/ets
   ets_view.dart80%100%100%80%27–29, 79–81
lib/features/ets/events/api-client
   hello_api_client.dart91.67%100%100%91.67%26
lib/features/ets/events/api-client/commands
   get_events_command.dart74.07%100%100%74.07%50, 58, 61, 64, 67, 70, 73
   get_organizer_command.dart92.31%100%100%92.31%26
   report_news_command.dart92.86%100%100%92.86%27
lib/features/ets/events/api-client/models
   organizer.dart100%100%100%</

@XavierPaquet-Rapold XavierPaquet-Rapold deleted the feature/day-view-calendar branch December 23, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LouisPhilippeHeon LouisPhilippeHeon LouisPhilippeHeon approved these changes

Assignees
No one assigned
Labels
feature: Schedule Issue concerning the schedule section of the application size: M version: Minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DavidMartel12 @LouisPhilippeHeon @HugoMigner @MysticFragilist