Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need help page improvements #1004

Merged
merged 14 commits into from
Jul 9, 2024
Merged

Need help page improvements #1004

merged 14 commits into from
Jul 9, 2024

Conversation

LouisPhilippeHeon
Copy link
Contributor

@LouisPhilippeHeon LouisPhilippeHeon commented Jul 5, 2024 •
edited
Loading

⁉️ Related Issue

closes #1002

📖 Description

Changements esthétiques dans la page besoin d'aide, voir screenshots.

🧪 How Has This Been Tested?

iOS, Android, vertical et horizontal.

☑️ Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • If needed, I added analytics.
  • Make sure to add either one of the following labels: version: Major,version: Minor or version: Patch.
  • Make sure golden files changes were reviewed and approved.

🖼️ Screenshots (if useful):

Capture d’écran, le 2024-07-05 à 17 35 08 Capture d’écran, le 2024-07-05 à 17 35 21

@LouisPhilippeHeon LouisPhilippeHeon marked this pull request as ready for review July 5, 2024 22:44
@LouisPhilippeHeon LouisPhilippeHeon requested a review from a team as a code owner July 5, 2024 22:44
XavierPaquet-Rapold
XavierPaquet-Rapold reviewed Jul 5, 2024
View reviewed changes
Copy link
Contributor

@XavierPaquet-Rapold XavierPaquet-Rapold left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/features/more/faq/faq_view.dart Show resolved Hide resolved
LouisPhilippeHeon and others added 2 commits July 5, 2024 19:01
@LouisPhilippeHeon
Merge branch 'master' into need-help-page-improvements
c77a044
@LouisPhilippeHeon
Merge branch 'master' into need-help-page-improvements
a96bacb 
# Conflicts:
#	lib/features/more/faq/faq_view.dart
#	test/ui/views/goldenFiles/newsDetailsView_1.png
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

Coverage after merging need-help-page-improvements into master will be

73.18%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib/constants
   preferences_flags.dart0%100%100%0%61, 66, 68, 70–72, 75, 77–80, 82, 84
   widget_helper.dart100%100%100%100%
   markers.dart100%100%100%100%
lib/features/app/analytics
   analytics_service.dart0%100%100%0%13–14, 17, 20–22, 25, 30, 32–34, 38, 40–41, 43
   remote_config_service.dart0%100%100%0%100, 103–105, 108–110, 113–115, 118–120, 123–125, 128–130, 133–135, 138–140, 143–144, 146–150, 154–156, 58–60, 63–65, 68–70, 73–75, 78–80, 83–85, 88–90, 93–95, 98–99
lib/features/app/error
   internal_info_service.dart0%100%100%0%18–21, 24–29, 32, 34–38, 42–43
lib/features/app/error/not_found
   not_found_view.dart94.74%100%100%94.74%92–93
   not_found_viewmodel.dart100%100%100%100%
lib/features/app/integration
   github_api.dart0%100%100%0%100–101, 104, 106, 110, 112–116, 118–119, 122, 124, 131–134, 138–139, 141, 39, 42–43, 47, 51–55, 57–58, 60, 62, 64–65, 68, 70, 77, 82–88, 92, 94, 96–98
   launch_url_service.dart0%100%100%0%16–18, 21–23, 26–31, 37, 55–56, 59
   networking_service.dart0%100%100%0%10–11, 13–15, 18–20
lib/features/app/monets_api
   monets_api_client.dart90.91%100%100%90.91%22
lib/features/app/monets_api/models
   mon_ets_user.dart50%100%100%50%29–33, 35, 37
lib/features/app/navigation
   navigation_service.dart0%100%100%0%27, 30–31, 33–34, 41–42, 45–46, 49–51, 53, 58, 61, 63–64, 67–69, 71–72
lib/features/app/presentation
   rive_animation_service.dart0%100%100%0%12–13, 16, 19–20, 28, 32–33, 35
   webview_controller_extension.dart88.89%100%100%88.89%21
lib/features/app/repository
   author_repository.dart0%100%100%0%13, 15
   course_repository.dart84.34%100%100%84.34%200, 205, 210–211, 213, 217, 219–220, 223–229, 234, 236, 239, 241–243, 246–251, 255, 259–261, 263, 267, 337, 345, 347, 532–533, 83
   news_repository.dart0%100%100%0%16, 21
   quick_link_repository.dart85.71%100%100%85.71%39–40
   user_repository.dart93.52%100%100%93.52%135–136, 186, 308, 310, 98–99
lib/features/app/signets-api
   signets_api_client.dart88.89%100%100%88.89%35, 45, 47, 49
   soap_service.dart100%100%100%100%
lib/features/app/signets-api/commands
   authentificate_command.dart0%100%100%0%18, 21, 24–28, 31
   get_course_reviews_command.dart100%100%100%100%
   get_course_summary_command.dart100%100%100%100%
   get_courses_activities_command.dart100%100%100%100%
   get_courses_command.dart100%100%100%100%
   get_programs_command.dart100%100%100%100%
   get_schedule_activities_command.dart100%100%100%100%
   get_sessions_command.dart100%100%100%100%
   get_student_info_command.dart100%100%100%100%
lib/features/app/signets-api/models
   course.dart80.52%100%100%80.52%102–105, 120, 122–131
   course_activity.dart81.40%100%100%81.40%83, 85–91
   course_evaluation.dart70.54%100%100%70.54%128, 167, 169–182, 184, 186–200, 49
   course_review.dart51.92%100%100%51.92%100–103, 51–58, 70, 72–79, 95, 97–99
   course_summary.dart86.84%100%100%86.84%106, 108–116
   schedule_activity.dart80.95%100%100%80.95%121, 123–133
   session.dart73.08%100%100%73.08%159, 161–173, 175, 177–189
   profile_student.dart82.14%100%100%82.14%56, 58–61
   program.dart81.13%100%100%81.13%100–106, 96, 98–99
lib/features/app/startup
   startup_viewmodel.dart92.50%100%100%92.50%103, 138–139
lib/features/app/storage
   cache_manager.dart0%100%100%0%30–31, 34–37, 40, 44, 46–50, 56, 58–61, 66, 68–71
   preferences_service.dart69.09%100%100%69.09%119–120, 122, 36, 38, 40, 43–45, 69–70, 80–82, 85, 87–88
   siren_flutter_service.dart0%100%100%0%13–14, 18–19, 23–25, 29–31, 35, 41
lib/features/app/widgets
   app_widget_service.dart77.42%100%100%77.42%71, 73–78
   bottom_bar.dart92.65%100%100%92.65%50, 52, 54, 59, 63
   dismissible_card.dart100%100%100%100%
   link_web_view.dart88.24%100%100%88.24%38–39
   base_scaffold.dart85.14%100%100%85.14%105, 134, 163–164, 166–168, 170–171, 173–174
   navigation_rail.dart64.18%100%100%64.18%41, 51, 53, 55, 58, 62, 68–69, 74–88, 90
lib/features/dashboard
   dashboard_view.dart78.78%100%100%78.78%154–157, 165–168, 176–178, 186–188, 196–198, 236–239, 253–255, 261–263, 271, 273–274, 292–295, 299–301, 327–328, 365–366, 378–379, 417–418, 465–467, 495–496, 518, 90
   dashboard_viewmodel.dart80.59%100%100%80.59%149–151, 153, 156, 243–244, 258–264, 266, 275–276, 318, 358–359, 361, 381, 385, 422, 424, 429, 467, 482, 484–486, 488, 493–494, 550, 555, 557–558, 560–561, 564–565, 567, 570, 572, 574–575, 577–578, 581–582, 594–595
lib/features/dashboard/widgets
   course_activity_tile.dart100%100%100%100%
   haptics_container.dart100%100%100%100%
lib/features/ets
   ets_view.dart80%100%100%80%27–29, 79–81
lib/features/ets/events/api-client
   hello_api_client.dart91.67%100%100%91.67%26
lib/features/ets/events/api-client/commands
   get_events_command.dart74.07%100%100%74.07%50, 58, 61, 64, 67, 70, 73
   get_organizer_command.dart92.31%100%100%92.31%26
   report_news_command.dart92.86%100%100%92.86%27
lib/features/ets/events/api-client/models
   organizer.dart100%100%100%100%
   paginated_news.dart31.03%100%100%31.03%

@LouisPhilippeHeon LouisPhilippeHeon self-assigned this Jul 9, 2024
EffBureau
EffBureau approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@EffBureau EffBureau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤓

@LouisPhilippeHeon LouisPhilippeHeon merged commit e8a9c5b into master Jul 9, 2024
7 checks passed
@LouisPhilippeHeon LouisPhilippeHeon deleted the need-help-page-improvements branch July 9, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierPaquet-Rapold XavierPaquet-Rapold XavierPaquet-Rapold approved these changes

@EffBureau EffBureau EffBureau approved these changes

Assignees

@LouisPhilippeHeon LouisPhilippeHeon

Labels
size: M version: Minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Le texte de la section besoin d'aide ne devrait pas être justifié.
4 participants
@LouisPhilippeHeon @EffBureau @XavierPaquet-Rapold @clubapplets-server