Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libqgtk3.so and other platformthemes that may lead to crashes #152

Closed
wants to merge 1 commit into from

Conversation

probonopd
Copy link
Member

Closes #150

@probonopd
Copy link
Member Author

probonopd commented Aug 28, 2020

Getting

-- Running input plugin: qt -- 

Running process: /tmp/AppImageUpdate-build-F1P5tL/linuxdeploy-plugin-qt-x86_64.AppImage --appdir AppImageUpdate.AppDir

munmap_chunk(): invalid pointer

resources/build-appimages.sh: line 78:  8203 Aborted                 (core dumped) ./linuxdeploy-"$ARCH".AppImage --appdir 

Possibly caused by linuxdeploy/linuxdeploy#143.

@TheAssassin
Copy link
Member

There's no reason to believe this is a good idea, other than some random experiments in #150. Mind to explain why how these are causing a crash? I think it was you who suggested to bundle these platform themes in the first place, so it would be appreciated if you could explain why they now fail, and whether there's changes needed in tools like linuxdeploy-plugin-qt (if it's a global issue, others could benefit from a solution as well).

Copy link
Member

@TheAssassin TheAssassin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

@probonopd
Copy link
Member Author

While I don't fully understand yet why they fail for some users, they do seem to be problematic, as removing them fixes the problems various users have reported.

And I was advocating for deploying libqgtk2* (without its dependencies - like Scribus is doing), not libqgtk3*. Actually it would be a good test if the affected users could try the Scribus AppImage and see if they experience the same crash with it.

@TheAssassin
Copy link
Member

Possibly related: #151 (comment).

@probonopd
Copy link
Member Author

Two years later, I was writing the exact same PR again when I found this.

We are getting lots and lots of error reports since years of AppImageUpdate crashing due to Gtk errors, and I am now sick and tired of it. Let's just remove all and everything related to Gtk and call it a day.

Unfortunately it seems that the LinuxDeploy plugin for Qt is what pulls this Gtk stuff in and there seems to be no obvious way to disable it...

probonopd added a commit that referenced this pull request May 21, 2022
probonopd added a commit that referenced this pull request May 21, 2022
probonopd added a commit that referenced this pull request May 21, 2022
probonopd added a commit that referenced this pull request May 21, 2022
probonopd added a commit that referenced this pull request May 21, 2022
probonopd added a commit that referenced this pull request May 21, 2022
probonopd added a commit that referenced this pull request May 21, 2022
@probonopd
Copy link
Member Author

TheAssassin added a commit that referenced this pull request May 21, 2022
The actual issue must and will be fixed in linuxdeploy-plugin-qt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash at startup on Ubuntu 20.04
2 participants