Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use pgvector for postgres image instead of building #851

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

khorshuheng
Copy link
Collaborator

Partially address #791 . As we are currently only using pgvector extension and not expecting to use additional extensions in the near future, there's little reason not to use pgvector image instead.

The alternative to this would be to publish our custom postgres image to dockerhub instead, so that the self hosting users do not have to build the postgres image when they need to install appflowy cloud.

Copy link
Collaborator

@Horusiath Horusiath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for that. If our requirements will change in the future, we may go back to our private Postgres Dockerfile approach.

@khorshuheng khorshuheng merged commit 5193d01 into main Sep 30, 2024
5 checks passed
@khorshuheng khorshuheng deleted the use-pgvector-image branch September 30, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants