Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add base margin to search feed #246

Merged
merged 2 commits into from
Dec 12, 2024
Merged

feat: add base margin to search feed #246

merged 2 commits into from
Dec 12, 2024

Conversation

nlewis84
Copy link
Contributor

@nlewis84 nlewis84 commented Dec 12, 2024 •
edited
Loading

🐛 Issue

Search Feed needs margin

✏️ Solution

Add margin to Search Feed

🔬 To Test

  1. cd web-embds
  2. yarn dev
  3. Have Cluster running locally
  4. Open the Search Embed
  5. See margin around the feed

📸 Screenshots

Before After
before.png after.png

@vercel Vercel
Copy link

vercel bot commented Dec 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apollos-micro-service ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 7:07pm
apollos-web-embeds ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 7:07pm

@nlewis84 Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nlewis84 nlewis84 marked this pull request as ready for review December 12, 2024 19:36
@nlewis84 nlewis84 requested a review from redreceipt December 12, 2024 19:36
@nlewis84 Graphite App
Copy link
Contributor Author

@redreceipt I updated the index.html so that this was easier to test.

@redreceipt redreceipt added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 1152c69 Dec 12, 2024
7 checks passed
@redreceipt redreceipt deleted the fix_no_margin_search_feed branch December 12, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redreceipt redreceipt redreceipt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlewis84 @redreceipt