Add commenting to web #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @conrad-vanl and the rest of your teammates on |
Merged
Graphite Automations"Warn authors when publishing large PRs" took an action on this PR • (04/04/24)1 teammate was notified to this PR based on Conrad VanLandingham's automation. |
conrad-vanl
force-pushed
the
04-02-add_close_button
branch
from
2b70a3a to
057dc72
Compare
conrad-vanl
force-pushed
the
04-04-add_commenting_to_web
branch
from
ceee645 to
e84ff81
Compare
nlewis84
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
This works for me. I've got a couple of screenshots and gifs for you if you want to check them out.
-
Double horizontal lines when there are no comments
-
Duplicate Comment error (you good with this?)
-
FeatureFeed could not render feature of type "AddCommentFeature" getting spammed in the console
-
This strange resizing of the text area after submitting a comment
conrad-vanl
force-pushed
the
04-02-add_close_button
branch
from
057dc72 to
0792333
Compare
conrad-vanl
force-pushed
the
04-04-add_commenting_to_web
branch
from
e84ff81 to
558d807
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Issue
There's no commenting on web
✏️ Solution
Add commenting on web! Built with quick and easy components, tried to handle most states/things but within constraints of current code standards.
🔬 To Test
💸
📸 Screenshots