Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add classnames for View All buttons #172

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Add classnames for View All buttons #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b845119
Add classnames for View All buttons
vinnyjth Feb 22, 2024
232af77
Merge branch 'main' into classnames-view-all-buttons
vinnyjth Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/web-shared/components/FeatureFeed/Features/HorizontalCardListFeature.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ function HorizontalCardListFeature(props = {}) {
title="View All"
variant="link"
onClick={handlePrimaryActionPress}
icon={<CaretRight size={18} weight="bold" />}
icon={<CaretRight className="primary-action-icon" size={18} weight="bold" />}
className="primary-action-button"
/>
) : null}
</Box>
Expand Down
5 changes: 3 additions & 2 deletions packages/web-shared/components/FeatureFeed/Features/HorizontalMediaListFeature.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ function HorizontalMediaListFeature(props = {}) {
if (item.action === 'OPEN_URL') {
analytics.track('OpenUrl', {
url: item?.relatedNode?.url,
});
});
return window.open(getURLFromType(item.relatedNode), '_blank');
}

Expand Down Expand Up @@ -93,7 +93,8 @@ function HorizontalMediaListFeature(props = {}) {
title="View All"
variant="link"
onClick={handlePrimaryActionPress}
icon={<CaretRight size={18} weight="bold" />}
icon={<CaretRight className="primary-action-icon" size={18} weight="bold" />}
className="primary-action-button"
/>
) : null}
</Box>
Expand Down
1 change: 1 addition & 0 deletions packages/web-shared/components/FeatureFeed/Features/VerticalCardListFeature.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ function VerticalCardListFeature(props = {}) {
variant="link"
onClick={handlePrimaryActionPress}
icon={<CaretRight size={18} weight="bold" />}
className="primary-action-button"
/>
) : null}
</Box>
Expand Down
Loading