Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when opening / closing event feeds #171

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Conversation

vinnyjth
Copy link
Member

🐛 Issue

Clicking "view app" on an events feed would crash the modal.

✏️ Solution

Properly safely check for a [0]th video

🔬 To Test

In web embeds.

This link should open, and not display an error screen.

📸 Screenshots

CleanShot.2024-02-22.at.09.02.14.mp4

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apollos-micro-service ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 2:08pm
apollos-web-embeds ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 2:08pm

Copy link
Contributor

@nlewis84 nlewis84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vinnyjth vinnyjth merged commit 326fa09 into main Feb 22, 2024
5 checks passed
@vinnyjth vinnyjth deleted the fix-crash-opening-events branch February 22, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants