Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue in Search bar placeholder overlap with icon #165

Merged
merged 8 commits into from
Feb 19, 2024

Conversation

rajitharussel
Copy link
Contributor

@rajitharussel rajitharussel commented Feb 9, 2024

🐛 Issue

when using an small screen size, Search bar place holder text overlaps with user avatar

✏️ Solution

un necessary padding removed which causes this text overlap

🔬 To Test

  1. Open feed contains search and check the Search bar in mobile screens.
  2. http://localhost:3000/?id=facing-your-saul-TWVkaWFDb250ZW50SXRlbS0wNzgwMWQ0Ni1iYWE4LTQ0ZGUtODEwNi1jMThlODA5YmNlZWI%3D

📸 Screenshots

Before

Screenshot 2024-02-19 at 16 11 49

After

Simulator Screenshot - iPhone 15 Pro Max - 2024-02-15 at 07 19 06

Copy link

vercel bot commented Feb 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apollos-micro-service ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 10:37am
apollos-web-embeds ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 10:37am

@redreceipt
Copy link
Member

redreceipt commented Feb 9, 2024

@rajitharussel can you show what it looks like when there's more text than will fit in the box

@rajitharussel
Copy link
Contributor Author

@rajitharussel can you show what it looks like when there's more text than will fit in the box

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-02-12.at.17.58.24.mp4

@redreceipt
Copy link
Member

Can we change the placeholder copy to "What are you looking for?". The current is too long

Screenshot 2024-02-12 at 10 33 21 AM

@rajitharussel
Copy link
Contributor Author

Can we change the placeholder copy to "What are you looking for?". The current is too long

Screenshot 2024-02-12 at 10 33 21 AM

@redreceipt only for the mobile or always?

@redreceipt
Copy link
Member

redreceipt commented Feb 12, 2024

I think always. @nlewis84 can overrule me though

@nlewis84
Copy link
Contributor

@rajitharussel Sorry I didn't see this earlier. We can do "What are you looking for?" always.

@nlewis84
Copy link
Contributor

Can you attach some before and after photos to this? It would be super helpful if you dropped a link to a feed into the test instructions. Will need a rebase, also.

@nlewis84 nlewis84 self-assigned this Feb 14, 2024
@rajitharussel
Copy link
Contributor Author

@rajitharussel Sorry I didn't see this earlier. We can do "What are you looking for?" always.

Can we change the placeholder copy to "What are you looking for?". The current is too long
Screenshot 2024-02-12 at 10 33 21 AM

@redreceipt only for the mobile or always?

added

Copy link
Contributor

@nlewis84 nlewis84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rajitharussel
Copy link
Contributor Author

Can you attach some before and after photos to this? It would be super helpful if you dropped a link to a feed into the test instructions. Will need a rebase, also.

updated the description

@rajitharussel rajitharussel merged commit 6749e7e into main Feb 19, 2024
6 checks passed
@rajitharussel rajitharussel deleted the main-fix-search-bar branch February 19, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants