Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clean up chip list spacing #164

Merged
merged 4 commits into from
Feb 14, 2024
Merged

fix: Clean up chip list spacing #164

merged 4 commits into from
Feb 14, 2024

Conversation

vinnyjth
Copy link
Member

@vinnyjth vinnyjth commented Feb 8, 2024

https://3.basecamp.com/3926363/buckets/32694519/card_tables/cards/7057831230#__recording_7062942883

✏️ Solution

  • Cleaned up some spacing issues on the item single
  • Cleaned up some overflow / scroll bar issues on the item single

🔬 To Test

on web-embeds

  1. http://localhost:3000/?id=facing-your-saul-TWVkaWFDb250ZW50SXRlbS0wNzgwMWQ0Ni1iYWE4LTQ0ZGUtODEwNi1jMThlODA5YmNlZWI%3D
  2. Open the search bar on the index.html!

📸 Screenshots

CleanShot 2024-02-08 at 10 35 19@2x CleanShot 2024-02-08 at 10 26 36@2x

Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apollos-micro-service ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 3:03pm
apollos-web-embeds ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 3:03pm

@vinnyjth
Copy link
Member Author

vinnyjth commented Feb 8, 2024

@conrad-vanl assigning you because nathan is ooo

margin-left: 1rem;
}
* > &:last-child {
margin-left: 1rem;
& > *:last-child {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote this CSS in the previous PR, had it working, then moved it to a different section and butchered it when re-writing 😅

@vinnyjth vinnyjth changed the title Clean up chip list spacing fix: Clean up chip list spacing Feb 8, 2024
@vinnyjth vinnyjth requested review from nlewis84 and removed request for conrad-vanl February 13, 2024 14:38
@vinnyjth vinnyjth assigned nlewis84 and unassigned conrad-vanl Feb 13, 2024
@nlewis84
Copy link
Contributor

nlewis84 commented Feb 13, 2024

Screenshot 2024-02-13 at 11 30 07 AM
@vinnyjth What's up with this bar? Is this a "me" problem?

Never mind, I reviewed below 👇

Copy link
Contributor

@nlewis84 nlewis84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of styling comments.

* > &:first-child {
.chip-list-feature ul {
overflow-x: scroll;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding padding-bottom: 1rem; here might be nice.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️ I'll take a look!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good without the scrollbar, looks not so good with the scrollbar. Margin might look great.
CleanShot 2024-02-13 at 12 57 46@2x

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splitting 1rem across margin + padding

CleanShot 2024-02-13 at 12 59 01@2x

Just margin

CleanShot 2024-02-13 at 12 59 11@2x

I think Iike splitting the most

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah Splitting works for me

packages/web-shared/components/Searchbar/Search.styles.js Outdated Show resolved Hide resolved
@vinnyjth
Copy link
Member Author

Screenshot 2024-02-13 at 11 30 07 AM @vinnyjth What's up with this bar? Is this a "me" problem?

Never mind, I reviewed below 👇

Thanks! what browser did you see that on?

@nlewis84
Copy link
Contributor

Thanks! what browser did you see that on?

Arc and Chrome

Copy link
Contributor

@nlewis84 nlewis84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants