-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Clean up chip list spacing #164
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@conrad-vanl assigning you because nathan is ooo |
margin-left: 1rem; | ||
} | ||
* > &:last-child { | ||
margin-left: 1rem; | ||
& > *:last-child { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote this CSS in the previous PR, had it working, then moved it to a different section and butchered it when re-writing 😅
Never mind, I reviewed below 👇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of styling comments.
* > &:first-child { | ||
.chip-list-feature ul { | ||
overflow-x: scroll; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding padding-bottom: 1rem;
here might be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👁️ I'll take a look!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah Splitting works for me
Co-authored-by: Nathan Lewis <[email protected]>
Thanks! what browser did you see that on? |
Arc and Chrome |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
https://3.basecamp.com/3926363/buckets/32694519/card_tables/cards/7057831230#__recording_7062942883
✏️ Solution
🔬 To Test
on
web-embeds
📸 Screenshots