fix: Misc style fixes (for Liquid) #156
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| sm: '250px', | ||
| md: '350px', | ||
| lg: '500px', | ||
| _: '90%', |
There was a problem hiding this comment.
I have seen this pattern several times in the codebase, but I think there's something wrong with it. These widths are coming through as [object Object]
There was a problem hiding this comment.
Maybe it's only a problem if there is only one responsive style and it should be "90%" in that case? maxWidth change up above may need that tweak also.
There was a problem hiding this comment.
This caught my eye because I was trying to figure out why the action list item in your description picture was forcing the caret to the right when it had a long title.
There was a problem hiding this comment.
@nlewis84 Were you able to recreate that carret being forced to the left? I think I fixed that but accidentally in dragged in an old screenshot but I'll check again :)
that's a good callout regarding the [object Object]. I think the code is working, in that the styles are being applied, but it's broken that the prop makes it all the way down to the dom. It should def be redirected into the stylesheet.
There was a problem hiding this comment.
I could not recreate that issue 😄
Not a blocking issue. This does seem to be working.
There was a problem hiding this comment.
Cool! I just confirmed right now also. You're right that I don't need the responsive object and I'm cleaning that up now before we merge
|
cleaned up. and spotted a bug with the positioning of the arrow (it was too high) that I fixed 
|
🐛 Issue
https://3.basecamp.com/3926363/buckets/32694519/card_tables/cards/7009918938
https://3.basecamp.com/3926363/buckets/32694519/card_tables/cards/7010425769
Solution
Testing
For testing the search bar width, you can click on any item on desktop. Here's an example:
https://apollos-web-embeds-git-cleanup-header-apollos-embeds.vercel.app/?id=in-training-for-reigning-TWVkaWFDb250ZW50SXRlbS1kODI0Yjg0ZS00MDFkLTQ0NzAtOGFlNi1mYjU3Y2U4NWUwMmI%3D
For testing the action list, click on the search bar in mobile view :)
✏️ Solution