Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Render a full feed on content items. #154

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Conversation

vinnyjth
Copy link
Member

@vinnyjth vinnyjth commented Jan 27, 2024

🐛 Issue

We should render any features we support on a content item, not just features specifically queried for by the content item query.

Provides support for: https://3.basecamp.com/3926363/buckets/32694519/card_tables/cards/6979833101

✏️ Solution

Use the featureFeed hook to query for a content item's features, rather than relying on a subquery of contentItem

🔬 To Test

  1. start web embeds
  2. visit this item
  3. You will see an action bar feature at the bottom

📸 Screenshots

CleanShot 2024-01-29 at 16 03 18@2x

Copy link

vercel bot commented Jan 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apollos-micro-service ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 2:49pm
apollos-web-embeds ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 2:49pm

@vinnyjth vinnyjth marked this pull request as ready for review January 29, 2024 20:55
@vinnyjth vinnyjth marked this pull request as draft January 29, 2024 20:55
Copy link
Contributor

@nlewis84 nlewis84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing checks out and this code LGTM
🐿️

@vinnyjth vinnyjth enabled auto-merge (squash) January 31, 2024 14:47
@vinnyjth vinnyjth merged commit b69445a into main Jan 31, 2024
4 of 5 checks passed
@vinnyjth vinnyjth deleted the full-feed-on-items branch January 31, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants