Properly classify model removals as breaking (#21)

Apodini · Aug 31, 2022 · 6d32d0d · 6d32d0d
1 parent 3279b97
commit 6d32d0d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/Resources/ExampleDocuments/migration_guide.json b/Resources/ExampleDocuments/migration_guide.json
@@ -705,7 +705,7 @@
         {
             "type": "removal",
             "id": "CategoryStatus",
-            "breaking": false,
+            "breaking": true,
             "solvable": false
         },
         {

diff --git a/Sources/ApodiniMigratorCompare/Comparators/Model/ModelsComparator.swift b/Sources/ApodiniMigratorCompare/Comparators/Model/ModelsComparator.swift
@@ -51,8 +51,7 @@ struct ModelsComparator: Comparator {
 
         for removal in removalCandidates where !pairs.contains(where: { $0.contains(removal.deltaIdentifier) }) {
             results.append(.removal(
-                id: removal.deltaIdentifier,
-                breaking: false
+                id: removal.deltaIdentifier
             ))
         }
 

diff --git a/Tests/ApodiniMigratorTests/ApodiniMigratorCompareTests/ModelsComparatorTests.swift b/Tests/ApodiniMigratorTests/ApodiniMigratorCompareTests/ModelsComparatorTests.swift
@@ -63,7 +63,7 @@ final class ModelsComparatorTests: ApodiniMigratorXCTestCase {
         let change = try XCTUnwrap(modelChanges.first)
         XCTAssertEqual(change.id, programmingLanguages.deltaIdentifier)
         XCTAssertEqual(change.type, .removal)
-        XCTAssertEqual(change.breaking, false)
+        XCTAssertEqual(change.breaking, true)
         XCTAssertEqual(change.solvable, false)
 
         let removalChange = try XCTUnwrap(change.modeledRemovalChange)