fix: issue where empty results were not returned properly from `make_…

…request()` (#96)

Co-authored-by: antazoey <[email protected]>

ape_alchemy/provider.py

@@ -303,10 +303,7 @@ def make_request(self, rpc: str, parameters: Optional[Iterable] = None) -> Any:
             )
             raise cls(message) from err
 
-        if isinstance(result, dict) and (res := result.get("result")):
-            return res
-
-        return result
+        return result["result"] if isinstance(result, dict) and "result" in result else result
 
     def send_private_transaction(self, txn: TransactionAPI, **kwargs) -> ReceiptAPI:
         """

setup.cfg

@@ -2,6 +2,7 @@
 max-line-length = 100
 ignore = E704,W503,PYD002,TC003,TC006
 exclude =
+	.venv*
 	venv*
 	docs
 	build

tests/test_providers.py

@@ -206,3 +206,14 @@ def rate_limit_hook(self, rpc, params):
     result = alchemy_provider.make_request("ape_testRateLimiting", parameters=[])
     assert rate_limit_tester.tries_made == rate_limit_tester.tries + 1
     assert result == {"success": True}
+
+
+def test_make_request_empty_result(alchemy_provider, mock_web3):
+    """
+    Testing the case when the result is empty that it still returns it
+    (and not the raw JSON response).
+    """
+    alchemy_provider._web3 = mock_web3
+    mock_web3.provider.make_request.return_value = {"jsonrpc": "2.0", "id": 8, "result": []}
+    result = alchemy_provider.make_request("ape_madeUpRPC", [])
+    assert result == []