This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
Fix #61 freeze/broken pipe after some idle time #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When keeping long-lived websocket connection, after some idle time
the connection will go into a bad state. Calling send() cause no
response at first and then broken pipe error is raised on the
subsequent call. The cause is that there is no designated thread
to keep the socket alive.
A possible drawback is that for short-lived / one-off call a thread will still be created and thrown away. If you feel this is excessive one possible solution is to add another config flag for long-live connection and only create keep alive thread in that case. Although the flag will only be applicable to websocket implementation at the moment. Let me know how do you like to proceed.
Testing Done
samsungctl -i
that after some idle time (1 mins, 5 mins), sending key commands now succeeds.