Fix Remnote2Obsidian script breaking with blank rem objects #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! I want to thank you for making such a great Remnote-to-Obsidian converter, it certainly saved me a few headaches when moving my notes over. It seems the original script ends up breaking whenever there are untitled blank rem objects in the
rem.jsonoutput, as it assumes every object in the list is a dictionary. When I checked the JSON, the untitled blank rems are instead in the following array format:[0]As these rems are completely empty there really isn't a need for them to be imported over, so I went ahead and added a check to the
getAllDocsfunction to ignore any non-dict objects.