Simplify #453
Draft
Simplify #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn type check of update operations into filter for all incorrect ops and return all instead of failing after the first.
- Streamlined the error handling - Added test to cover both pre and post commits - Adapted the tests to make changes more visible
All updates have been checked at top-level, a second check in the materializer is not required.
Apply effects in a fold
- remove some pass throughs - Replace recursive version with fold - unify naming: create_snapshot -> new
- Simplified several helper functions in clocksi_materializer - Added missing test case - Adapted naming and typing information to be less confusing (hopefully)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR needs investigation. Introduces non-deterministic bugs.