patch

AnourValar · Dec 19, 2024 · 39d2fb6 · 39d2fb6
1 parent 9f9cd60
commit 39d2fb6
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/composer.json b/composer.json
@@ -11,7 +11,7 @@
     "require-dev": {
         "phpunit/phpunit": "^10.0",
         "orchestra/testbench": "^8.6",
-        "phpstan/phpstan": "^1.10",
+        "phpstan/phpstan": "^2.0",
         "friendsofphp/php-cs-fixer": "^3.26",
         "squizlabs/php_codesniffer": "^3.7",
         "psalm/plugin-laravel": "^2.8"

diff --git a/phpstan.neon b/phpstan.neon
@@ -4,7 +4,7 @@ parameters:
         - src
         - tests
 
-    # The level 9 is the highest level
+    # The level 10 is the highest level
     level: 5
 
     ignoreErrors:
@@ -17,19 +17,21 @@ parameters:
         - '#Call to an undefined method#'
         - '#If condition is always true#'
         - '#Call to an undefined static#'
-        - '#Method class\@anonymous\/tests\/ServiceTest.php\:12\:\:obtain\(\)#'
         - '#AnourValar\\LaravelAtom\\Tests\\Models\\Post\:\:\$data#'
-        - '#with return type void returns array\<int\, array\<int\, array\<int\|string\,#'
+        - '#is used zero times and#'
+        - '#should be covariant with return type \(int\<0\, max\>\) of method Countable\:\:count\(\)#'
 
     excludePaths:
 
     checkFunctionNameCase: true
     checkInternalClassCaseSensitivity: true
-    checkAlwaysTrueInstanceof: true
     reportMaybesInMethodSignatures: true
     reportStaticMethodSignatures: true
     checkUninitializedProperties: true
     checkDynamicProperties: true
     reportAlwaysTrueInLastCondition: true
     reportWrongPhpDocTypeInVarTag: true
     checkMissingCallableSignature: true
+    reportPossiblyNonexistentGeneralArrayOffset: true
+    reportPossiblyNonexistentConstantArrayOffset: true
+    reportAnyTypeWideningInVarTag: true
diff --git a/src/Http/Middleware/Web/Select2.php b/src/Http/Middleware/Web/Select2.php
@@ -43,6 +43,10 @@ public function handle(Request $request, Closure $next): Response
      */
     private function convertResponse(\Symfony\Component\HttpFoundation\Response &$response): void
     {
+        if ($response->getStatusCode() != 200) {
+            return;
+        }
+
         $content = $response->getOriginalContent();
 
         if (

diff --git a/tests/MapperCollectionTest.php b/tests/MapperCollectionTest.php
@@ -52,7 +52,7 @@ public function test_simple(array $data)
     }
 
     /**
-     * @return void
+     * @return array
      */
     public static function provideSimpleData()
     {
-Original file line number
+Diff line change
@@ Expand Up @@
          */
         private function convertResponse(\Symfony\Component\HttpFoundation\Response &$response): void
         {
+            if ($response->getStatusCode() != 200) {
+                return;
+            }
             $content = $response->getOriginalContent();
             if (
@@ Expand Down @@