Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improving the dark mode functionality on home page #867

Closed
wants to merge 1 commit into from

Conversation

charu1110
Copy link

Description

  1. i made certain changes to improve the text visibility in dark mode ..
    the issue was that the text becomes invisible when dark mode was on but i made changes so as in dark the text color will change accordingly in header section .

  2. the same issue was on card section so i made a background set when dark mode is on and it matches with the color scheme too !

Related Issues

Type of PR

  • ()

Screenshots / videos (if applicable)

BEFORE :
image
image

AFTER :
image
image
image

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @charu1110! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work!

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for vintagevibe ready!

Name Link
🔨 Latest commit 1b15db7
🔍 Latest deploy log https://app.netlify.com/sites/vintagevibe/deploys/678501bf8dab510008ab1892
😎 Deploy Preview https://deploy-preview-867--vintagevibe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Anjaliavv51
Copy link
Owner

/assign

@charu1110
Copy link
Author

@Anjaliavv51 is it good to merge ?

@Anjaliavv51
Copy link
Owner

@charu1110 I think feature need to be added to the whole website so that I can assign u Advanced

@charu1110
Copy link
Author

@Anjaliavv51 ok i will work on it .

@charu1110 charu1110 closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[bug]: Improving the dark mode functionality on home page .
2 participants