Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Added logic for reordering books on the index page, as well as logic for reordering edited book after the
stock_amount
has been changed. For more background, see ticket #JIRA-002.Why?
These changes complete the user book management experience, ensuring that the books are displayed in the desired order.
How?
This includes a migration, updated factory and seeder, form request classes, updated controller, new repository and a service for book management. Used form request classes to move validation out of controllers and moved business logic to a service.
Testing?
Testing reordering books:
Testing changing book stock amount:
Screenshots?
Anything else?
It would be good to consider having one set of Up, Down and Move (with book selection) since this way the user can enter multiple "ups" and "downs" but the Move button is tied to one book, so one set of those fields feels more intuitive.