Make googletest not be a git submodule, and instead clone it separately in the CI script #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly in the CI script
|
I think I would personally prefer the submodule approach (in fact I added it in the first place), but I could certainly live with this one, too. |
|
Thanks! |
Thank you for the PR Juha. As you know I have an extremely limited understanding of CMake. Nevertheless, I'm confident that your changes are fine. But are you suggesting there's a better way? I've followed your link and it seems to me that I committed your PR#44 back then, so I don't understand what you're suggesting would be better? |
|
Sorry for being unclear, Angus! I think it's a matter of taste, and if this change helps @yoavmil, then I'm fine with this. |
jiajuncccc
added a commit
to jiajuncccc/Clipper2
that referenced
this pull request
Dec 15, 2023
* remotes/origin/main: Minor code tidy Added CLIPPER2_HI_PRECISION option in CMakeLists.txt Additional minor tweaks to cpp/benchmark tests Make googletest not be a git submodule, and instead clone it separately in the CI script (AngusJohnson#745) fix compiler warning of -Wunused-but-set-parameter with -fno-exceptions (AngusJohnson#744) Additional tweaks to GetIntersectPtBenchmark.cpp Additional GetIntersectPtBenchmark tweaks Fixed incorrect code comment Added new GetIntersectPoint benchmark test Updated other benchmark tests. Code formatting only (removed trailing spaces) Fixed minor typecasting issues (AngusJohnson#727) More tweaks to PointInPolygon benchmarking. Allow using external gtest with GTest:: qualified names (AngusJohnson#737) Fixed a significant (though uncommon) bug in polygon clipping (AngusJohnson#736) Fixed bugs in PointInPolygon benchmark testing. Minor tweaks to PointInPolygon benchmark testing. Fixed a minor syntax error tripping some C++ compilers Version 1.3.0 1. Fixed a significant offsetting bug introduced in previous update (AngusJohnson#733) 2. Fixed a C++ compile error when 32bit compiling (AngusJohnson#727) 3. Minor tweak to CMakeLists.txt (C++) (AngusJohnson#728) 4. Will now offset 'flat' polygons (Disc.AngusJohnson#725) 5. Reminder: recent change in open path offsetting behaviour (AngusJohnson#707) 6. Reminder: recent changes to clipper.export.h data structures. Fixed a typo and tweaked documentation Version 1.2.4 Changes since ver 1.2.3 include: 1. Important: Offsetting open path behaviour has changed. The delta now behaves as it did in Clipper1 (See Issue AngusJohnson#707) 2. Important: Data structures of exported values in clipper.export.h have changed. 3. Minor bugfixes to PolyTree nesting (AngusJohnson#679, AngusJohnson#687) 4. Numerous minor bugfixes to polygon offsetting (AngusJohnson#703, AngusJohnson#715, AngusJohnson#724) 5. Fixed an obscure bug in polygon clipping caused by horizontal spikes (AngusJohnson#720) 6. Significantly improved documentation. Additional minor bugfix to ClipperOffset (AngusJohnson#724 & Disc.AngusJohnson#726)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is supposed to address this request: #737 (comment)