Feat/script migration #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sogipec
reviewed
May 3, 2024
|
You can add as well a script to setup the LZ token contract -> as if CoreBorrow had as a governor the deployer -> this way there's no msig tx to do and we can just run the script to set the token up on the chain (provided that it's already setup in a way) and then execute all the setup tx, then removing governance from the deployer and adding the actual governing address.
|
sogipec
reviewed
May 3, 2024
sogipec
reviewed
May 6, 2024
| } else { | ||
| proxyAdmin = _chainToContract(chainId, ContractType.ProxyAdmin); | ||
| } | ||
| if (vm.keyExistsJson(json, ".coreBorrow")) { |
There was a problem hiding this comment.
is the json per chain or something like this?
There was a problem hiding this comment.
the json so far is for all chains. In my mind we deploy one chain at a time so no real need for multiples
sogipec
reviewed
May 6, 2024
GuillaumeNervoXS
approved these changes
Jun 13, 2024
sogipec
reviewed
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.