feat: start of gas estimation #23
Conversation
0xtekgrinder
force-pushed
the
feat/gas-estimation
branch
from
e2dcd37 to
2f49280
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=======================================
Coverage 85.49% 85.49%
=======================================
Files 7 7
Lines 255 255
=======================================
Hits 218 218
Misses 37 37 ☔ View full report in Codecov by Sentry. |
| @@ -102,6 +102,7 @@ function main { | |||
| if [ $? -ne 0 ]; then | |||
| echo "" | |||
| echo "Script failed" | |||
| exit 1 | |||
There was a problem hiding this comment.
It doesn't really change anything no?
There was a problem hiding this comment.
it will just. exit the script with a error code which is a bit better than exiting as a success
| @@ -88,6 +88,9 @@ uint256 constant CHAIN_SOURCE = CHAIN_ETHEREUM; | |||
| uint256 constant BASE_18 = 1e18; | |||
| uint256 constant BASE_9 = 1e9; | |||
|
|
|||
| uint256 constant BASE_GAS = 100000; | |||
| uint256 constant GAS_MULTIPLIER = 150000; // 1.5x | |||
There was a problem hiding this comment.
I just tried locally and the eth sent seems pretty low (0.001), I am not sure it will be enough for the message. So we can be more conservative and set this value to x3 first and then decrease if we are really too high
There was a problem hiding this comment.
I have tested on gnosis to polygon and it worked pretty well. Maybe we can increase it but 3x seems a bit too much
No description provided.