-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added IAudioSessionEvents callbacks & Example #36
Conversation
Following "IAudioSessionEvents" callbacks are supported: OnSimpleVolumeChanged() OnStateChanged() OnSessionDisconnected() Added an example to show the new features
Added if __name__ == "__main__": and the example script can now run "normally" (without python -i mode)
pycaw/pycaw.py and examples/session_callback_example.py are now style compliant to PEP 8 - Indentation and Import order fixes - to long lines fix
* example: added missing f strings examples/session_callback_example.py: Due to heavy formatting i forgot to add back in f strings. Also fixed missing whitespace between oneline strings.
Oooooops that where a lot of commits ;) Its my first time contributing to a Github project ^^ But now everything should work as expected! |
I think i will come back later with an even bigger pull request ;) Im working on a project and i need AudioSessionNotification::OnSessionCreated too |
Thanks for contributing. Edit: why did you close the pull request by the way? |
i have no clue 😉 i thought with all this back and forth ... that i should make a new request later and add there also:
i thought it would make it easier for you to test all this if its all in one run ;) ... but youre right small is better ;) then you know where possible errors are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hard work and for fixing the linter.
For your info, you can squash commits and push force in order to make a PR with one commit.
I'll squash upon merge
Yeah it was even fun trying all out and fixing it 😁 |
Implementing #27 and more usefull callbacks!
Following "IAudioSessionEvents" callbacks are supported:
OnSimpleVolumeChanged()
OnStateChanged()
OnSessionDisconnected()
Added an example to show the new features
Thanks @AndreMiras for this project!