Adding User Manager #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-Guldborg
force-pushed
the
feature/user-manager
branch
from
ff2a040 to
a7bb8f3
Compare
A-Guldborg
force-pushed
the
feature/user-manager
branch
from
8c081e3 to
b7428e0
Compare
A-Guldborg
added a commit
to AnalogIO/analog-core
that referenced
this pull request
Feb 27, 2024
Implements the endpoint `PUT /api/v2/webhooks/accounts/user-group`,
allowing an external service to update user groups in bulk.
Example request body:
```
{
"privilegedUsers": [
{ "accountId": 123, "userGroup": "Manager" },
{ "accountId": 124, "userGroup": "Barista" }
]
}
```
The X-Api-Key header should be present on the request with a valid API
key.
The userGroup should be one of:
- Barista
- Manager
- Board
- (Customer will also work, but will have the same effect as not
specifying the user in the request)
### Notes on testing
I have been unable to implement an integration test, since
EFCore.InMemory does not seem to support the performance-optimized
ExecuteUpdate that is implemented in EF Core 7 and used in this service.
Reference:
https://stackoverflow.com/questions/74907256/ef-7-new-executedelete-and-executeupdate-methods-not-working-on-an-in-memory-d
### Business logic
Initially, business logic was implemented using client-side hashing to
verify duplicate requests did not use many resources. Later, it was
changed to server-side hashing however hashing was completely removed
again, as it would cause weird behaviour in combination with the below
mentioned existing endpoint. Now it will be clearer that the state in
the external system will correct itself if analog-core and the external
system are out of sync.
### Notes on affected existing endpoints
This change will also mark our `PATCH /api/v2/account/<id>/user-group`
endpoint, as any calls to the new endpoint will override any user-groups
set by the old patch endpoint.
The endpoint is used by the Shifty User Manager from
AnalogIO/shifty-webapp#21
---------
Co-authored-by: Jonas Anker Rasmussen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a way to manage the group that a user belongs to.
Fixes #6
User interface looks like this:
We can only edit one element at a time (remaining edit icons are disabled until you commit / cancel changes).
Search field uses backend search engine meaning we only pass a query
Only UserGroup field is editable. MudTable allows easily defining which elements are editable if we want to extend this in the future.