-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds Product selection when using ticket #567
Conversation
main: Add support for using concrete products when claiming a ticket -> Upgraded ticket use flow to accommodate the selection of menu items explicitly. -> The last selected menu item is cached locally for each ticket (cache cleared on logout). other: Simplified the Product feature file structure. Add improvements to network request handling by adopting a TaskEither type for better composability. Added package Hive for local storage Rename some files and refactor several imports across the codebase Fixed various minor bugs, tightened type constraints, and made use of pattern matching & fpdart types.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
=======================================
Coverage ? 68.76%
=======================================
Files ? 133
Lines ? 1697
Branches ? 0
=======================================
Hits ? 1167
Misses ? 530
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are frankly so many changes, I don't follow all of it.
With that said, only some smaller comments, where I would like some thoughts from you.
Also, are you sure that caching the last used menu item on swiping will have the intended outcome? I'm thinking that people will tend to be lazy, and just use whatever it was already on when swiping. This would be a shame, since it would basically make the data we get from it worthless. Is this something you have considered?
It was implemented to help people feel like not much extra work is being done. We can ask baristas about how precise customer swipes 1-2 weeks in with this feature enabled. |
Add support for using concrete products when claiming a ticket:
other: