fix(ci): development version built in release pipeline #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build configurations across Android and iOS build pipelines were updated to enforce the specification of 'development' or 'production' as mandatory build types. Introduced a shared 'verify_build_type' action that validates this input. This change ensures that artifacts are built against the correct backend environments and clarifies the pipeline behavior by removing ambiguity in build type selection. Additionally, updated steps to reflect the new build type validation and adjusted environment setup actions to accommodate the enforcement of build types. Finally, this commit fixes the following yml syntax/schema errors: - inputs.<id>.options for actions - env on the root level of an action
marfavi
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
marfavi
commented
Dec 8, 2023
fremartini
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the release pipeline bug that caused building a development version for release (in the first commit), and increases code robustness to prevent the same bug from appearing again (in the second commit).
The error was caused by a bug in actions code, which passed an ill-defined input variable (whether to build a dev/prod app) to another action. The input variable expected by the second action was optional, defaulting to build a dev version if no input variable is present.
Build configurations across Android and iOS build pipelines were updated to enforce the specification of 'development' or 'production' as mandatory build types. Introduced a shared 'verify_build_type' action that validates this input. This change ensures that artifacts are built against the correct backend environments and clarifies the pipeline behavior by removing ambiguity in build type selection. Additionally, updated steps to reflect the new build type validation and adjusted environment setup actions to accommodate the enforcement of build types.
Finally, this PR fixes the following yml syntax/schema errors:
inputs.<id>.optionsin an actionenvon the root level of an action