refactor: opening hours #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fremartini
force-pushed
the
frem/update_opening_hours
branch
from
e63c907 to
4b47b7b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-prerelease #541 +/- ##
==================================================
Coverage ? 72.56%
==================================================
Files ? 130
Lines ? 1578
Branches ? 0
==================================================
Hits ? 1145
Misses ? 433
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
marfavi
requested changes
Nov 16, 2023
Uses the flutter-native TimeOfDay class, which has localized time formatting. This has been extended with comparison methods <= and isInTimeslot. Timeslot class simplifies with this change. Simplify DateService to only contain one getter. Make sure of fpdart's Option instead of null values. Use None for closed days. Clean up tests and use NiceMocks for mocking.
|
Awaiting dev build to publish so we can smoke test. Otherwise looks OK |
marfavi
added a commit
that referenced
this pull request
Nov 16, 2023
Fix opening hours to match the cafe Uses the flutter-native TimeOfDay class, which has localized time formatting. This has been extended with comparison methods <= and isInTimeslot. Timeslot class simplifies with this change. Simplify DateService to only contain one getter. Make sure of fpdart's Option instead of null values. Use None for closed days. Clean up tests, add more tests, and use NiceMocks for mocking. --------- Co-authored-by: Omid Marfavi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix opening hours to match the cafe
Uses the flutter-native TimeOfDay class, which has localized time formatting.
This has been extended with comparison methods <= and isInTimeslot.
Timeslot class simplifies with this change.
Simplify DateService to only contain one getter.
Make sure of fpdart's Option instead of null values. Use None for closed days.
Clean up tests, add more tests, and use NiceMocks for mocking.