Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Android SDKs, Java JDK and action versions to newer versions #522

Merged
merged 9 commits into from
Oct 15, 2023

Conversation

jonasanker
Copy link
Member

No description provided.

@ghost
Copy link

ghost commented Oct 15, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (041b53d) 73.93% compared to head (5802993) 73.93%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #522   +/-   ##
=======================================
  Coverage   73.93%   73.93%           
=======================================
  Files         128      128           
  Lines        1527     1527           
=======================================
  Hits         1129     1129           
  Misses        398      398           
Flag Coverage Δ
unittests 73.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonasanker jonasanker marked this pull request as ready for review October 15, 2023 09:37
Copy link
Member

@fremartini fremartini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should pin the version to avoid stuff breaking because of new versions.

@jonasanker
Copy link
Member Author

jonasanker commented Oct 15, 2023

i think we should pin the version to avoid stuff breaking because of new versions.

I don't disagree as such. However we also be fine to lock into just the major or minor version as you wouldn't normally expect breaking behaviour between patches.

Could we maybe just lock in in the minor version?

@jonasanker jonasanker requested a review from fremartini October 15, 2023 10:25
@fremartini
Copy link
Member

i think we should pin the version to avoid stuff breaking because of new versions.

I don't disagree as such. However we also be fine to lock into just the major or minor version as you wouldn't normally expect breaking behaviour between patches.

Could we maybe just lock in in the minor version?

Minor versions would be fine. Expectations and reality have a tendency to not align

@jonasanker jonasanker mentioned this pull request Oct 15, 2023
@jonasanker
Copy link
Member Author

i think we should pin the version to avoid stuff breaking because of new versions.

I don't disagree as such. However we also be fine to lock into just the major or minor version as you wouldn't normally expect breaking behaviour between patches.
Could we maybe just lock in in the minor version?

Minor versions would be fine. Expectations and reality have a tendency to not align

It seems you can not refer to a minor version. Only major versions or absolute versions are supported, thus I have changed all actions to refer their latest version.

@fremartini Please re-review

@jonasanker jonasanker self-assigned this Oct 15, 2023
@jonasanker jonasanker enabled auto-merge (squash) October 15, 2023 11:52
@jonasanker jonasanker merged commit 2bf53c6 into main Oct 15, 2023
7 checks passed
@jonasanker jonasanker deleted the pr/jra/update-sdks branch October 15, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants