-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Android SDKs, Java JDK and action versions to newer versions #522
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #522 +/- ##
=======================================
Coverage 73.93% 73.93%
=======================================
Files 128 128
Lines 1527 1527
=======================================
Hits 1129 1129
Misses 398 398
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should pin the version to avoid stuff breaking because of new versions.
I don't disagree as such. However we also be fine to lock into just the major or minor version as you wouldn't normally expect breaking behaviour between patches. Could we maybe just lock in in the minor version? |
Minor versions would be fine. Expectations and reality have a tendency to not align |
It seems you can not refer to a minor version. Only major versions or absolute versions are supported, thus I have changed all actions to refer their latest version. @fremartini Please re-review |
No description provided.