Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email validation logic in Forgot Passcode page #521

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

marfavi
Copy link
Member

@marfavi marfavi commented Oct 14, 2023

Inverted an if-else that would determine whether to show the "no account exists" error or not.

Fix #520

Inverted an if-else that would determine whether to show the "no account exists" error or not.
@ghost
Copy link

ghost commented Oct 14, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@marfavi marfavi requested review from jonasanker and a team October 14, 2023 22:32
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a52acdb) 73.93% compared to head (aafdc3b) 73.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #521   +/-   ##
=======================================
  Coverage   73.93%   73.93%           
=======================================
  Files         128      128           
  Lines        1527     1527           
=======================================
  Hits         1129     1129           
  Misses        398      398           
Flag Coverage Δ
unittests 73.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonasanker jonasanker merged commit 041b53d into main Oct 14, 2023
7 checks passed
@jonasanker jonasanker deleted the forgot-passcode-fix-email-check branch October 14, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forgot password fails email verification
2 participants