Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading indicator to splash page after duration #512

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

fremartini
Copy link
Member

closes #419

@fremartini fremartini requested a review from a team September 28, 2023 15:23
@ghost
Copy link

ghost commented Sep 28, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (facb451) 74.22% compared to head (02a1c27) 74.22%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #512   +/-   ##
========================================
  Coverage    74.22%   74.22%           
========================================
  Files          127      127           
  Lines         1521     1521           
========================================
  Hits          1129     1129           
  Misses         392      392           
Flag Coverage Δ
unittests 74.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fremartini fremartini enabled auto-merge (squash) September 28, 2023 15:43
Copy link
Member

@marfavi marfavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest of review in person

lib/core/widgets/pages/splash/splash_loading_page.dart Outdated Show resolved Hide resolved
Copy link
Member

@marfavi marfavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@fremartini fremartini merged commit ad17be8 into develop Sep 28, 2023
7 checks passed
@fremartini fremartini deleted the frem/splash_loading branch September 28, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show loading spinner in the splash screen after a set delay
2 participants