Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate receipt_overlay and loading_overlay #511

Merged
merged 6 commits into from
Sep 28, 2023
Merged

Conversation

fremartini
Copy link
Member

closes #386

@fremartini fremartini requested a review from marfavi September 28, 2023 14:54
@ghost
Copy link

ghost commented Sep 28, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ad17be8) 74.22% compared to head (f73d070) 73.93%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #511      +/-   ##
===========================================
- Coverage    74.22%   73.93%   -0.30%     
===========================================
  Files          127      128       +1     
  Lines         1521     1527       +6     
===========================================
  Hits          1129     1129              
- Misses         392      398       +6     
Flag Coverage Δ
unittests 73.93% <0.00%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...core/network/network_request_executor_mapping.dart 100.00% <ø> (ø)
lib/core/strings.dart 30.95% <0.00%> (-1.55%) ⬇️
lib/core/external/screen_brightness.dart 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fremartini fremartini enabled auto-merge (squash) September 28, 2023 15:43
Copy link
Member

@marfavi marfavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 change otherwise OK

marfavi
marfavi previously approved these changes Sep 28, 2023
@fremartini fremartini merged commit 782d307 into develop Sep 28, 2023
5 of 7 checks passed
@fremartini fremartini deleted the frem/overlay branch September 28, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using functions instead of factories concerning overlays
2 participants