Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resend verification code #507

Merged
merged 5 commits into from
Sep 21, 2023
Merged

Resend verification code #507

merged 5 commits into from
Sep 21, 2023

Conversation

fremartini
Copy link
Member

No description provided.

@fremartini fremartini requested a review from a team September 15, 2023 09:48
@fremartini fremartini marked this pull request as draft September 15, 2023 09:48
@fremartini
Copy link
Member Author

@marfavi two elements need styling. Can you do it?

@ghost
Copy link

ghost commented Sep 15, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@fremartini fremartini marked this pull request as ready for review September 15, 2023 10:51
@fremartini fremartini enabled auto-merge (squash) September 15, 2023 11:15
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 46.34% and project coverage change: -1.08% ⚠️

Comparison is base (e03bc91) 85.35% compared to head (ae095e1) 84.27%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #507      +/-   ##
===========================================
- Coverage    85.35%   84.27%   -1.08%     
===========================================
  Files          114      116       +2     
  Lines         1140     1164      +24     
===========================================
+ Hits           973      981       +8     
- Misses         167      183      +16     
Flag Coverage Δ
unittests 84.27% <46.34%> (-1.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lib/features/login/domain/usecases/login_user.dart 100.00% <ø> (ø)
lib/utils/reactivation_authenticator.dart 100.00% <ø> (ø)
...n/data/datasources/account_remote_data_source.dart 58.33% <28.57%> (ø)
...features/login/presentation/cubit/login_cubit.dart 63.33% <33.33%> (-13.94%) ⬇️
...et/data/datasources/ticket_remote_data_source.dart 90.47% <33.33%> (-9.53%) ⬇️
lib/core/errors/failures.dart 68.75% <50.00%> (+10.41%) ⬆️
...features/login/presentation/cubit/login_state.dart 90.90% <50.00%> (-9.10%) ⬇️
lib/core/widgets/list_entry.dart 100.00% <100.00%> (ø)
...ogin/domain/errors/email_not_verified_failure.dart 100.00% <100.00%> (ø)
...b/features/login/domain/usecases/resend_email.dart 100.00% <100.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fredpetersen fredpetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When dialog is styled, and variable name is addressed, this seems good to me :)

lib/base/strings.dart Outdated Show resolved Hide resolved
@fremartini
Copy link
Member Author

@fredpetersen styling should be part of another PR

Copy link
Contributor

@fredpetersen fredpetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now :)

Did you make an issue for styling this later?

@fremartini fremartini merged commit 1fd284e into develop Sep 21, 2023
6 of 7 checks passed
@fremartini fremartini deleted the frem/resend_verification_code branch September 21, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants