Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce IsPerk property on Products #207

Merged
merged 15 commits into from
Oct 26, 2023
Merged

Introduce IsPerk property on Products #207

merged 15 commits into from
Oct 26, 2023

Conversation

jonasanker
Copy link
Member

No description provided.

@jonasanker jonasanker self-assigned this Sep 14, 2023
@ghost
Copy link

ghost commented Sep 14, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023 •
edited
Loading

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (60e5afd) 7.99% compared to head (20afd3f) 7.97%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           develop    #207      +/-   ##
==========================================
- Coverage     7.99%   7.97%   -0.03%     
==========================================
  Files          157     159       +2     
  Lines        10015   10048      +33     
  Branches       459     459              
==========================================
  Hits           801     801              
- Misses        9196    9229      +33     
  Partials        18      18
Files Coverage Δ
...d.Models/DataTransferObjects/Product/ProductDTO.cs 0.00% <0.00%> (ø)
.../CoffeeCard.Library/Utils/ProductUserGroupUtils.cs 0.00% <0.00%> (ø)
...d/CoffeeCard.Library/Services/v2/ProductService.cs 46.66% <0.00%> (+5.49%) ⬆️
...eeCard.WebApi/Controllers/v2/ProductsController.cs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonasanker jonasanker changed the title Introduce ProductType on ProductDTO Introduce IsPerk property on Products Sep 21, 2023
marfavi
marfavi previously approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@marfavi marfavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

fredpetersen
fredpetersen approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@fredpetersen fredpetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jonasanker jonasanker enabled auto-merge (squash) October 26, 2023 17:01
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@jonasanker jonasanker merged commit 4673fac into develop Oct 26, 2023
@jonasanker jonasanker deleted the pr/jra/producttype branch October 26, 2023 17:04
@marfavi marfavi mentioned this pull request Dec 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredpetersen fredpetersen fredpetersen approved these changes

@marfavi marfavi marfavi left review comments

Assignees

@jonasanker jonasanker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonasanker @codecov-commenter @marfavi @fredpetersen