Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Show selected answer in button style #677

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

drikusroor
Copy link
Contributor

@drikusroor drikusroor commented Dec 19, 2023

This PR makes sure that whenever a button in a button group is "selected", this selection will be made clear visually to the user after navigating to the next form element. Like a checkbox, but then for a selected button.

Additionally, it adds the checked and aria-checked attributes to the buttons (which are in fact radio buttons) with the correct value.

Lastly, I've upgraded Storybook to a new version.

Resolves #656

@drikusroor drikusroor self-assigned this Dec 19, 2023
@drikusroor drikusroor force-pushed the fix/show-selected-answer branch from 0777f84 to 4ef5a1b Compare December 20, 2023 13:56
@drikusroor drikusroor force-pushed the fix/show-selected-answer branch from 4ef5a1b to b966d7b Compare December 21, 2023 11:34
@drikusroor drikusroor merged commit 9e95245 into develop Dec 21, 2023
9 checks passed
@drikusroor drikusroor deleted the fix/show-selected-answer branch January 8, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep "focus" on buttons when handling a form with multiple elements
2 participants